Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model require forward to have *args, **kwargs in 1.0.6 #203

Open
atong01 opened this issue Oct 3, 2023 · 2 comments
Open

Model require forward to have *args, **kwargs in 1.0.6 #203

atong01 opened this issue Oct 3, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@atong01
Copy link
Member

atong01 commented Oct 3, 2023

torchdyn>=1.0.3 breaks if a model does not have *args, **kwargs in the forward method. This breaks downstream code which has custom models compatible with previous torchdyn versions. I propose to remove this requirement.

atong01/conditional-flow-matching#60

@atong01 atong01 added the bug Something isn't working label Oct 3, 2023
@Manaro-Alpha
Copy link

@atong01 is there any solution to the above problem?

@atong01
Copy link
Member Author

atong01 commented Aug 6, 2024

I have added args and kwargs to all my models... This is far from ideal, but it's somewhat annoying to fix here and I haven't had time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants