configs write in binary mode AND are encoded in the event of unicode #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On win32 when the filename is given at instantiation time it was saving the files with \r\r\n at eol. If 'newlines' was set to '\n' it was saving files with \r\n. Changing file open to binary fixes this so the write() doesn't redo the line endings.
The doc said it uses os.sep, but it should read os.linesep for default for newlines
…writing out in binary mode; handling encoding that in a py2/3-compatible way
robdennis
added a commit
that referenced
this pull request
Mar 11, 2014
configs write in binary mode AND are encoded in the event of unicode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pulling in MichaelHipps proposed changes, I worked to get the unit tests passing on *nix at least, and that necessitated an additional change to how we write things out (need to encode the string that we're writing to file)