Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump .NET SDK version #250

Merged
merged 3 commits into from Nov 20, 2020
Merged

bump .NET SDK version #250

merged 3 commits into from Nov 20, 2020

Conversation

dsyme
Copy link
Collaborator

@dsyme dsyme commented Nov 20, 2020

Bump so we can use F# 5.0 features (.NET 5.0 SDK is now requried)

Looks like we also requires a .NET 3.1 SDK to actually run tests

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #250 (dda64df) into dev (efa5640) will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #250      +/-   ##
==========================================
+ Coverage   63.62%   64.02%   +0.39%     
==========================================
  Files          19       19              
  Lines        5608     6136     +528     
  Branches     1416     1471      +55     
==========================================
+ Hits         3568     3928     +360     
- Misses       1269     1405     +136     
- Partials      771      803      +32     
Impacted Files Coverage Δ
src/DiffSharp.Core/Tensor.fs 60.40% <0.00%> (-8.95%) ⬇️
src/DiffSharp.Core/DiffSharp.Numerical.fs 77.63% <0.00%> (-3.95%) ⬇️
src/DiffSharp.Core/Scalar.fs 8.33% <0.00%> (-0.49%) ⬇️
src/DiffSharp.Core/RawTensor.fs 85.62% <0.00%> (-0.38%) ⬇️
src/DiffSharp.Backends.Torch/Torch.RawTensor.fs 78.41% <0.00%> (+0.18%) ⬆️
src/DiffSharp.Core/Util.fs 55.56% <0.00%> (+0.24%) ⬆️
src/DiffSharp.Core/Data.fs 74.67% <0.00%> (+0.69%) ⬆️
src/DiffSharp.Core/Optim.fs 83.65% <0.00%> (+0.83%) ⬆️
src/DiffSharp.Core/Extensions.fs 54.29% <0.00%> (+1.81%) ⬆️
...iffSharp.Backends.Reference/Reference.RawTensor.fs 60.58% <0.00%> (+2.03%) ⬆️
... and 8 more

@dsyme dsyme merged commit e5f6813 into DiffSharp:dev Nov 20, 2020
@gbaydin
Copy link
Member

gbaydin commented Nov 28, 2020

Hi @dsyme do you know why we need dotnet 3.1 for the tests?

@dsyme
Copy link
Collaborator Author

dsyme commented Nov 30, 2020

Hi @dsyme do you know why we need dotnet 3.1 for the tests?

The tests run as netcoreapp3.1, I think the CI installation technique doesn't automatically install the runtime for netcoreapp3.1.

I tried net5 when I did this but hit some issue - it might have BenchmarkDotnet, I'm not sure.

We should be able to move to purely net5 soon I think. Likely best to wait a month or two while other tools adjust

@gbaydin
Copy link
Member

gbaydin commented Nov 30, 2020

Ok, I could also test this within a Docker environment to inspect what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants