-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev kwargs #10
Dev kwargs #10
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #10 +/- ##
==========================================
+ Coverage 95.61% 95.63% +0.01%
==========================================
Files 8 8
Lines 456 458 +2
Branches 24 25 +1
==========================================
+ Hits 436 438 +2
Misses 10 10
Partials 10 10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this looks really great! Thanks for putting this work in, Ralf. Also, I didn't know know about the review feature: I'll start using it when merging my branches into dev in the future.
I’m slowly getting the hang of it ;-)
In the future, do you think we should always assign reviewers to our pull requests or just go ahead and merge them if git gives the green light?
… On 29. Nov 2017, at 16:26, Erik Henning Thiede ***@***.***> wrote:
@ehthiede approved this pull request.
Wow, this looks really great! Thanks for putting this work in, Ralf. Also, I didn't know know about the review feature: I'll start using it when merging my branches into dev in the future.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#10 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARuMPj63UBDKGn1AdFcDx4yXbXrW8RfRks5s7Xe-gaJpZM4Qupkf>.
|
I merged. Should we delete the dev_kwargs branch or keep it? |
I suppose we can leave it up to individual discretion, based on how complex / disruptive the commit is. It's probably overkill for small commits, but maybe we can use it just for big changes / changes to the interface (under-the-hood tweaks and bugfixes. I do like it because it gives me a better sense of what is going on with the codebase, which should hopefully help me avoid merge conflicts in the future. Also, since in practice most of us will be running our codes on the dev branch, this prevents us from accidentally breaking each others code's without forewarning (hopefully). |
Merge this with dev at your pleasure.