Add option IndentWsdl to control if the generated WSDL should be indented #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nted or not Removed field _indentWsdl from SoapMessageEncoder. This information is now directly passed into the WriteMessageAsync method. The new option IndentWsdl can be used to control if the WSDL should be indented or not. By default, it uses the same value as IndentXml, for backwards compatibility.
|
Looks good. Thanks! |
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the option
IndentXmlcan be used to control if the generated XML is indented or not. This applies to both: the SOAP response XML and the generated WSDL.It would be nice to control both of these independently. For example, the XML for the SOAP responses should not be indented, but the XML for the WSDL should be indented.
I propose to add a new configuration option
IndentWsdl. If this option is explicitly set, it will control if the generated WSDL is indented or not. If it is not set, it will default to the setting ofIndentXml, so existing users should not notice a difference in behavior.