XmlSerializer WSDL: Fix generated schema for DateTimeOffset #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XmlSerializer will serialize a DateTimeOffset simply as a string. Adjusted the DateTimeOffset test so that it works for both, DataContractSerializer and XmlSerializer. Fixes DigDes#1013
|
Seems to be the right thing to do! Thanks! |
|
Thank you for merging! Would it be possible to build a new NuGet package with the latest changes? Having an officially released NuGet package available would make deployment much easier for my situation.🙂 |
Sure! I'll try to get that done in a bit |
|
Great, thank you! 🙂 |
|
Done! |
|
Thank you very much, unfortunately I have found another issue (#1015). Well that's life 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XmlSerializer will serialize a DateTimeOffset simply as a string.
Adjusted the DateTimeOffset test so that it works for both, DataContractSerializer and XmlSerializer.
Fixes #1013