Depend on ASP.NET 2.1 packages for netstandard2.0 package #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lowered referenced package versions because the 2.1 versions are supported by Microsoft, while the 2.2 versions are not. Fixes DigDes#993
vidrenning
changed the title
|
Thank you! |
|
Thank you for merging the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SoapCore depends on Microsoft.AspNetCore.Http 2.2.0. This version is not supported anymore by Microsoft. When looking at https://www.nuget.org/packages/Microsoft.AspNetCore.Http, you can see that the newest version 2.2.2 from the 2.2 branch is from 2019, but the newest version 2.1.34 from the 2.1 branch is from 2022. The version 2.2.2 is marked as deprecated, but version 2.1.34 is not.
In this link you can see the list of supported ASP.NET Core 2.1 packages: https://dotnet.microsoft.com/en-us/platform/support/policy/aspnet/2.1-packages
Lowered referenced package versions to 2.1 for the netstandard2.0 build.
Fixes #993