Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade actix version & Rust edition #8

Merged
merged 4 commits into from
Apr 30, 2022
Merged

Upgrade actix version & Rust edition #8

merged 4 commits into from
Apr 30, 2022

Conversation

hgonomeg
Copy link
Contributor

As simple as the title puts it

@Diggsey
Copy link
Owner

Diggsey commented Apr 29, 2022

Thanks for the PR - since this upgrades actix which is a breaking change, could you also bump the version of this crate (to 0.4.0)?

@hgonomeg
Copy link
Contributor Author

Thanks for the PR - since this upgrades actix which is a breaking change, could you also bump the version of this crate (to 0.4.0)?

Sure

@Diggsey
Copy link
Owner

Diggsey commented Apr 30, 2022

Thanks 👍

@Diggsey Diggsey merged commit a9b13c2 into Diggsey:master Apr 30, 2022
@palfrey
Copy link

palfrey commented Feb 10, 2023

@Diggsey @hgonomeg This breaks the build with 1.40.0 which means test_minimum doesn't work. Do you want to upgrade that minimum version or revert this?

@palfrey palfrey mentioned this pull request Feb 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hgonomeg @Diggsey @palfrey