Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: correct key_tests #18

Merged
merged 2 commits into from
Apr 7, 2021
Merged

test: correct key_tests #18

merged 2 commits into from
Apr 7, 2021

Conversation

SmartArray
Copy link

@SmartArray SmartArray commented Apr 2, 2021 •
edited
Loading

DigiByte specific key_tests

What is the intention of this PR?

This PR fixes the key_tests with DigiByte's specific Network Parameters.

Description of the changes

The commit SmartArray@f0656a6 alters the Bitcoin Test Vectors in such a way that they fit DigiByte's implementation (Network Parameters, Address Prefixes, etc.) and result in a 100% integration test rate for the test key_tests.
An additional file contrib/testgen/key_tests.test_vectors.md has been added for documentation purposes.

How to verify?

  1. Change to the directory src/test
  2. Compile the test suite
  3. Run it using
./test_digibyte --run_test=key_tests

Expected outcome

$ ./test_digibyte --run_test=key_tests                   
Running test cases...
*** No errors detected

@SmartArray SmartArray marked this pull request as ready for review April 4, 2021 07:22
gto90
gto90 approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

digicontributer
digicontributer approved these changes Apr 7, 2021
View reviewed changes
Copy link

@digicontributer digicontributer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@gto90 gto90 merged commit 4b8ded0 into DigiByte-Core:develop Apr 7, 2021
@SmartArray SmartArray deleted the tests/key_tests branch April 8, 2021 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digicontributer digicontributer digicontributer approved these changes

@gto90 gto90 gto90 approved these changes

@digibyte digibyte Awaiting requested review from digibyte

Assignees

@SmartArray SmartArray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SmartArray @digicontributer @gto90