Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 10 Functional Tests #190

Merged
merged 7 commits into from Mar 10, 2024
Merged

Fix 10 Functional Tests #190

merged 7 commits into from Mar 10, 2024

Conversation

JaredTate
Copy link

This PR fixes 10 functional tests.

To test this:

Compile:

  ./autogen.sh
  ./configure
  make -j 8

Run Specific Functional Tests

test/functional/test_runner.py rpc_packages.py p2p_addr_relay.py feature_coinstatsindex.py wallet_abandonconflict.py wallet_avoidreuse.py wallet_txn_clone.py --jobs=2

Screenshot 2024-03-10 at 9 20 34 AM

gto90
gto90 approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Jongjan88
Copy link

10 test are passing.
Screenshot from 2024-03-10 16-48-52

Jongjan88
Jongjan88 approved these changes Mar 10, 2024
View reviewed changes
Copy link

@Jongjan88 Jongjan88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

ycagel
ycagel approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Great work @JaredTate!

@ycagel ycagel merged commit 8a26836 into DigiByte-Core:develop Mar 10, 2024
@Jongjan88 Jongjan88 mentioned this pull request Mar 20, 2024
Merged
@JaredTate JaredTate deleted the fix-tests branch March 29, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycagel ycagel ycagel approved these changes

@gto90 gto90 gto90 approved these changes

@Jongjan88 Jongjan88 Jongjan88 approved these changes

@SmartArray SmartArray Awaiting requested review from SmartArray

@digicontributer digicontributer Awaiting requested review from digicontributer

@j50ng j50ng Awaiting requested review from j50ng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JaredTate @Jongjan88 @ycagel @gto90