Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Updated README with badges #41

Merged
merged 5 commits into from May 2, 2021
Merged

Docs: Updated README with badges #41

merged 5 commits into from May 2, 2021

Conversation

ChillingSilence
Copy link

I have updated the README with badges from Shields.io including:

  • Live build status based on the "Build and check" CI actions
  • Live details of downloads (since changing to DigiByte-Core repo)
  • Live overview of pulls / issues
  • Live commit activity
  • Details of the latest release version + release date
    ...and more :-)

@ChillingSilence
Copy link
Author

I note that I'm currently getting an error for the LICENSE at the end:
https://img.shields.io/github/license/DigiByte-Core/digibyte
Screen Shot 2021-04-29 at 10 04 53 PM

However it seems to be correct when you go to that URL directly

marpme
marpme previously approved these changes May 1, 2021
README.md Outdated Show resolved Hide resolved
Use develop, not master

Co-authored-by: Marvin \0x1f977 <7430964+marpme@users.noreply.github.com>
@ChillingSilence
Copy link
Author

Well spotted, thanks mate, will include that :)

marpme
marpme previously approved these changes May 1, 2021
gto90
gto90 previously approved these changes May 1, 2021
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Great addition @ChillingSilence . I think we should pull this into the release branch as well.

@gto90 gto90 changed the title Updated README with badges Docs: Updated README with badges May 1, 2021
@j50ng
Copy link
Member

j50ng commented May 1, 2021

ACK

@marpme - thank you for all your help and providing the base of the CI integration for us! 🙏

@SmartArray SmartArray dismissed stale reviews from gto90 and marpme via 4c52fdc May 2, 2021 04:22
@SmartArray
Copy link

What about adding the DigiByte logo under the shields?

Copy link

@SmartArray SmartArray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ACK

Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@gto90 gto90 merged commit 880e510 into DigiByte-Core:develop May 2, 2021
@JaredTate
Copy link

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants