Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from Upstream Master #154

Merged
merged 78 commits into from
Feb 20, 2019
Merged

Conversation

vjFaLk
Copy link

@vjFaLk vjFaLk commented Feb 18, 2019

Please read the pull request checklist to make sure your changes are merged: https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist

jay-parikh and others added 30 commits February 8, 2019 11:13
…g_msg

fix: validation message for work order
- Some fields like barcodes cannot be copied in Item Variants
- Wrote a patch that deletes the fields if they exist
- Also, validate in controller
fix: errors in deferred revenue booking
fix: Make work order from production plan considering already ordered qty
@coveralls
Copy link

coveralls commented Feb 18, 2019

Pull Request Test Coverage Report for Build 491

  • 73 of 302 (24.17%) changed or added relevant lines in 21 files are covered.
  • 49 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 51.74%

Changes Missing Coverage Covered Lines Changed/Added Lines %
erpnext/init.py 0 1 0.0%
erpnext/accounts/report/general_ledger/general_ledger.py 0 1 0.0%
erpnext/accounts/report/utils.py 0 1 0.0%
erpnext/accounts/utils.py 1 2 50.0%
erpnext/stock/doctype/stock_entry/stock_entry.py 1 2 50.0%
erpnext/accounts/report/accounts_receivable/accounts_receivable.py 4 6 66.67%
erpnext/selling/report/address_and_contacts/address_and_contacts.py 0 2 0.0%
erpnext/stock/doctype/item/item.py 12 14 85.71%
erpnext/patches/v11_0/remove_barcodes_field_from_copy_fields_to_variants.py 0 4 0.0%
erpnext/regional/report/electronic_invoice_register/electronic_invoice_register.py 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
erpnext/accounts/doctype/pricing_rule/pricing_rule.py 1 72.76%
erpnext/accounts/deferred_revenue.py 2 19.19%
erpnext/stock/doctype/stock_entry/stock_entry.py 5 74.38%
erpnext/support/doctype/issue/issue.py 41 46.73%
Totals Coverage Status
Change from base Build 484: -0.1%
Covered Lines: 32852
Relevant Lines: 63495

💛 - Coveralls

deepeshgarg007 and others added 18 commits February 19, 2019 08:40
Added setup.py for italy under regional
Included fiscal regimes, tax exemption reasons and custom fields

Issue #16259
fixes:
removed cleanup_files from italy/utils
removed extract_doc_number from italy/utils
added country filter to italian localization patch
replaced dict assignment with dot operator in prepare_invoice
correcions in e-invoice xml following changes in prepare_invoice
added setup_report in patch
added section for e-invoicing custom fields in company
added Italy in test_company
validation for missing code on mode of payment
UOM from settings
Replace str with cstr
feat(regional): Italian Localization and E-Invoicing export
fix: Removed precision from multiple doctypes
…for_rate_pricing_rule

fix: multi-uom not working for the pricing rule rate
Received Qty Label rename to accepted qty in purchase invoice
fix: Fetch precision form system settings in Sales invoice payment(POS)
…s-barcodes

fix: Validate invalid fields in Item Variant Settings
moved state codes to init, rewired patch
added logic to autoset state code on address validate
handled multiple names for Italy
refactored validate_address_italy to validate_address
fix(regional,italy): added state code on address, updated patch
fix: AR/AP report based on account type
@Bloomstack Bloomstack deleted a comment Feb 19, 2019
@Bloomstack Bloomstack deleted a comment Feb 20, 2019
@vjFaLk vjFaLk merged commit ad6f66a into Bloomstack:bloomstack-staging Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet