Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(selling): added delivery days to customer doctype #488

Merged
merged 29 commits into from
Sep 8, 2020
Merged

feat(selling): added delivery days to customer doctype #488

merged 29 commits into from
Sep 8, 2020

Conversation

MyuddinKhatri
Copy link

@MyuddinKhatri MyuddinKhatri commented Aug 19, 2020

Required for Bloomstack/bloomstack_core#396.


Task

Customer

  • Add a hidden data field called Delivery Days to store the entered input from the user
  • Add a HTML field to show the days of the week as separate checkbox options (refer to the Employee Attendance Tool)
  • Collect input from the user in the HTML field, and compile it into the Delivery Days field

@coveralls
Copy link

coveralls commented Aug 19, 2020

Pull Request Test Coverage Report for Build 2022

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 2012: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1760

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 1759: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

erpnext/selling/doctype/customer/customer.js Outdated Show resolved Hide resolved
erpnext/selling/doctype/customer/customer.json Outdated Show resolved Hide resolved
erpnext/selling/doctype/customer/customer.json Outdated Show resolved Hide resolved
erpnext/selling/doctype/customer/customer.json Outdated Show resolved Hide resolved
erpnext/selling/doctype/customer/customer.js Outdated Show resolved Hide resolved
@Alchez
Copy link

Alchez commented Aug 24, 2020

@MyuddinKhatri, the styling looks off, are we tackling that later?

image

Also, please rename "Delivery Window" to "Delivery Preferences"? And check the Codacy issues.

@MyuddinKhatri
Copy link
Author

@MyuddinKhatri, the styling looks off, are we tackling that later?

image

Also, please rename "Delivery Window" to "Delivery Preferences"? And check the Codacy issues.

Yes @Alchez the styling part will be taken care by @nehasacher143 and i'll do the changes.

@Alchez Alchez marked this pull request as draft August 25, 2020 08:30
@Alchez Alchez marked this pull request as ready for review September 4, 2020 08:12
@Alchez
Copy link

Alchez commented Sep 4, 2020

@MyuddinKhatri, please check the issues reported by Codacy for this one

@hrwX
Copy link

hrwX commented Sep 7, 2020

@MyuddinKhatri, the styling looks off, are we tackling that later?
image
Also, please rename "Delivery Window" to "Delivery Preferences"? And check the Codacy issues.

Yes @Alchez the styling part will be taken care by @nehasacher143 and i'll do the changes.

There is a field MultiCheck or MultiSelect fieldtype in frappe where you just pass the values as options and the formatting will be handled by the field controller

@MyuddinKhatri
Copy link
Author

@MyuddinKhatri, the styling looks off, are we tackling that later?
image
Also, please rename "Delivery Window" to "Delivery Preferences"? And check the Codacy issues.

Yes @Alchez the styling part will be taken care by @nehasacher143 and i'll do the changes.

There is a field MultiCheck or MultiSelect fieldtype in frappe where you just pass the values as options and the formatting will be handled by the field controller

@Alchez and @hrwX have a look I have done the changes
Customer_delivery_Days

erpnext/selling/doctype/customer/customer.js Outdated Show resolved Hide resolved
erpnext/selling/doctype/customer/customer.js Outdated Show resolved Hide resolved
erpnext/selling/doctype/customer/customer.js Outdated Show resolved Hide resolved
erpnext/selling/doctype/customer/customer.js Outdated Show resolved Hide resolved
erpnext/selling/doctype/customer/customer.js Outdated Show resolved Hide resolved
erpnext/selling/doctype/customer/customer.js Outdated Show resolved Hide resolved
erpnext/selling/doctype/customer/customer.js Outdated Show resolved Hide resolved
erpnext/selling/doctype/customer/customer.js Outdated Show resolved Hide resolved
@Alchez Alchez merged commit 1b8f6f2 into Bloomstack:staging Sep 8, 2020
@Alchez Alchez deleted the customer-delivery-days branch September 8, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants