You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Alchez
merged 29 commits into
Bloomstack:staging
from
MyuddinKhatri:customer-delivery-daysSep 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MyuddinKhatri, the styling looks off, are we tackling that later?
Also, please rename "Delivery Window" to "Delivery Preferences"? And check the Codacy issues.
Yes @Alchez the styling part will be taken care by @nehasacher143 and i'll do the changes.
There is a field MultiCheck or MultiSelect fieldtype in frappe where you just pass the values as options and the formatting will be handled by the field controller
@MyuddinKhatri, the styling looks off, are we tackling that later?
Also, please rename "Delivery Window" to "Delivery Preferences"? And check the Codacy issues.
Yes @Alchez the styling part will be taken care by @nehasacher143 and i'll do the changes.
There is a field MultiCheck or MultiSelect fieldtype in frappe where you just pass the values as options and the formatting will be handled by the field controller
@Alchez and @hrwX have a look I have done the changes
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for Bloomstack/bloomstack_core#396.
Task
Customer