Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Split plant batch into new batch #565

Merged
merged 8 commits into from
Sep 28, 2020
Merged

fix: Split plant batch into new batch #565

merged 8 commits into from
Sep 28, 2020

Conversation

vishdha
Copy link

@vishdha vishdha commented Sep 16, 2020 •
edited
Loading

TASK ID: Asana

  • Make un-track field read only after save
  • make field read only of statistic section
  • Split current plant batch into new plant batch
  • update untracked count from previous plant batch

Peek 2020-09-16 15-46

@coveralls
Copy link

coveralls commented Sep 16, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2275

  • 1 of 10 (10.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Changes Missing Coverage Covered Lines Changed/Added Lines %
erpnext/agriculture/doctype/plant_batch/plant_batch.py 1 10 10.0%
Totals Coverage Status
Change from base Build 2261: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

Alchez
Alchez suggested changes Sep 16, 2020
View reviewed changes
Copy link

@Alchez Alchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neilLasrado @vishdha

Will the split only happen on untracked qty? Can it happen on any other type of qty in the plant batch?

erpnext/agriculture/doctype/plant_batch/plant_batch.js Outdated Show resolved Hide resolved
erpnext/agriculture/doctype/plant_batch/plant_batch.js Outdated Show resolved Hide resolved
erpnext/agriculture/doctype/plant_batch/plant_batch.js Outdated Show resolved Hide resolved
erpnext/agriculture/doctype/plant_batch/plant_batch.py Outdated Show resolved Hide resolved
@vishdha
Copy link
Author

vishdha commented Sep 16, 2020 •
edited
Loading

@neilLasrado @vishdha

Will the split only happen on untracked qty? Can it happen on any other type of qty in the plant batch?

Nope. I discussed with @neilLasrado

@vishdha vishdha requested a review from Alchez September 18, 2020 05:42
@vishdha vishdha requested a review from Alchez September 21, 2020 04:02
Alchez
Alchez suggested changes Sep 21, 2020
View reviewed changes
erpnext/agriculture/doctype/plant_batch/plant_batch.py Outdated Show resolved Hide resolved
erpnext/agriculture/doctype/plant_batch/plant_batch.py Outdated Show resolved Hide resolved
erpnext/agriculture/doctype/plant_batch/plant_batch.py Outdated Show resolved Hide resolved
erpnext/agriculture/doctype/plant_batch/plant_batch.py Outdated Show resolved Hide resolved
erpnext/agriculture/doctype/plant_batch/plant_batch.js Outdated Show resolved Hide resolved
erpnext/agriculture/doctype/plant_batch/plant_batch.py Outdated Show resolved Hide resolved
@vishdha vishdha requested a review from Alchez September 22, 2020 13:32
@vishdha vishdha requested a review from Alchez September 23, 2020 12:03
neilLasrado
neilLasrado previously approved these changes Sep 23, 2020
View reviewed changes
@neilLasrado
Copy link
Member

@vishdha Can you please resolve the conflicts and push?

@Alchez Alchez merged commit 15e2193 into Bloomstack:staging Sep 28, 2020
@Alchez Alchez deleted the split_plant_batch branch September 28, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alchez Alchez Alchez approved these changes

@MyuddinKhatri MyuddinKhatri Awaiting requested review from MyuddinKhatri

@neilLasrado neilLasrado Awaiting requested review from neilLasrado

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vishdha @coveralls @neilLasrado @Alchez