forked from frappe/erpnext
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(accounts): set non-zero cultivation tax for transaction #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2396
💛 - Coveralls |
hrwX
suggested changes
Oct 8, 2020
hrwX
suggested changes
Oct 13, 2020
@vishdha There are commits from devarsh in your PR, if they are intentional then cool, else please clean the branch |
hrwX
suggested changes
Oct 22, 2020
@vishdha can you have a look at Himanshu's suggestions. |
…nd minor changes added
hrwX
approved these changes
Nov 2, 2020
neilLasrado
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK ID: https://bloomstack.com/desk#Form/Task/TASK-2020-01913
TASK ID: https://bloomstack.com/desk#Form/Task/TASK-2020-01527
fixed show only cultivation tax row which has amount
fixed tax breakup
before:
![Peek 2020-10-30 11-50](https://user-images.githubusercontent.com/6947417/97667582-3a4dc280-1aa6-11eb-9a0d-0a9461bdff40.gif)
after:
![Peek 2020-10-30 11-45](https://user-images.githubusercontent.com/6947417/97667436-dfb46680-1aa5-11eb-815d-f3acf444822c.gif)