Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add non standard field in dashboard #620

Merged
merged 7 commits into from
Oct 13, 2020
Merged

fix: add non standard field in dashboard #620

merged 7 commits into from
Oct 13, 2020

Conversation

hrwX
Copy link

@hrwX hrwX commented Oct 2, 2020

  • set non standard fieldname for dashboard query since subscription now uses dynamic field for customer
  • add dashboard link in supplier too, since subscriptions now support supplier too
  • fix the following query
    image

@coveralls
Copy link

coveralls commented Oct 2, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2399

  • 4 of 8 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Changes Missing Coverage Covered Lines Changed/Added Lines %
erpnext/buying/doctype/supplier/supplier.py 2 4 50.0%
erpnext/selling/doctype/customer/customer.py 2 4 50.0%
Totals Coverage Status
Change from base Build 2394: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

vishdha
vishdha reviewed Oct 5, 2020
View reviewed changes
erpnext/selling/doctype/customer/customer_dashboard.py Outdated
@@ -12,7 +12,8 @@ def get_data():
'Payment Entry': 'party',
'Quotation': 'party_name',
'Opportunity': 'party_name',
'Contract': 'party_name'
'Contract': 'party_name',
'Subscription': 'party'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrwX Make sure subscription has party link field? change this to customer.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishdha New features were merged in (subscription)[https://github.com//pull/589], in which customer has been removed and replaced with party_type and party.

@hrwX hrwX requested a review from vishdha October 6, 2020 07:11
@hrwX hrwX requested a review from vishdha October 13, 2020 06:22
@sahil28297 sahil28297 merged commit 1fa300d into Bloomstack:staging Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil28297 sahil28297 sahil28297 approved these changes

@vishdha vishdha Awaiting requested review from vishdha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hrwX @coveralls @vishdha @sahil28297