Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartquotes not working on title page #136

Closed
hochleitner opened this issue May 23, 2022 · 2 comments · Fixed by #149
Closed

smartquotes not working on title page #136

hochleitner opened this issue May 23, 2022 · 2 comments · Fixed by #149
Assignees
Labels
bug Issue or PR related to bugs in the documents or the build system. needs investigation Issue or PR dealing with (yet) unclear behavior.
Milestone

Comments

@hochleitner
Copy link
Member

The smartquotes option does not affect anything entered in the title page macros. While probably expected, students came to rely on the option and therefore a lot of documents are handed in with the wrong quotes in the title.

Applying the smart quotes to the title page would be beneficial.

@hochleitner hochleitner added bug Issue or PR related to bugs in the documents or the build system. needs investigation Issue or PR dealing with (yet) unclear behavior. labels May 23, 2022
@hochleitner hochleitner self-assigned this May 23, 2022
@imagingbook
Copy link
Collaborator

Apparently quote substitution by csquotes gets activated at \begin{document} only. Thus a simple solution is to place \begin{document} before \title{...} to make smartquotes work inside the title as well. I suggest to make this change in the template.
Alternatively, one could use \enquote{...} in the title and leave everything else unchanged.

@hochleitner hochleitner added this to the Release 2023 milestone Nov 11, 2022
@hochleitner
Copy link
Member Author

I ran some tests, and as far as I can tell, it makes no difference if the \title, \author, and all our other commands are placed before or after \begin{document}. The file builds just fine, and the meta-data set by hyperref is also okay in the final PDF.

I suggest moving the definitions after \begin{document} because many students use quotes in their titles. Since they rely on smart quotes, I've seen printed theses with ugly quotes on the title page (the curse of making things easier).

Should we encounter a package that needs this data set in the preamble, we can always re-evaluate which is more important.

I'll open a PR with the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue or PR related to bugs in the documents or the build system. needs investigation Issue or PR dealing with (yet) unclear behavior.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants