-
-
Notifications
You must be signed in to change notification settings - Fork 89
Python 3.10 fails to handle VERSION_FILE_FILENAME not existing at update_url #306
Comments
The application update lifecycle works fine when using python 3.9, so this appears to be a python related change. I've also tested this using the latest git commit and it has the same behaviour as using the 4.0 @ pypi. |
@shauneccles I have the same problem I guess 307 So what is the solution? |
Copy your versions.gz multiple times and rename so you have one of each of these files: (need to sit on your download server alongside versions.gz) |
I'm seeing something similar on Python 3.9.7 with pyupdater 4.0. The problem starts in FileDownloader._create_response(), which returns The
At first sight, a quick fix could be to replace line 551 in client/init.py by: ...
if isinstance(data, dict) and "signature" in data.keys():
... However, that would mean we still end up with a log message In fact the problem is that decompressing ...
data = fd.download_verify_return()
try:
if data is None:
raise IOError('decompressing None makes no sense') # <<<<<<<<<<< added this
decompressed_data = _gzip_decompress(data)
except IOError:
... @JMSwag Maybe an |
A similar issue arises in Client._get_key_data(), again due to BTW: Shouldn't this say |
happens on pyupdater 4.0 or 3.1.0
Is the final error, have traced it back to https://github.com/Digital-Sapphire/PyUpdater/blob/main/pyupdater/client/__init__.py#L448 failing silently, returning
None
, and then not raising an exception.The text was updated successfully, but these errors were encountered: