Fix multiple issues related to release 4.0 #322

dennisvang · 2022-01-04T21:48:21Z

This should fix the following issues:

catch FileNotFoundError, due to missing manifest, in utils.make_archive()

add test for utils.make_archive(), reproducing issue 304

fix Package.name_regex

introduce a parse_archive_name function, with tests

use parse_archive_name to fix Package.extract_info removed Package._parse_package_name, now unused

cherry-pick VALID_CHANNELS from bce7d36 (issue311)

introduce a gen_pep440_version(), similar to gen_user_friendly_version, with tests

refactor gen_pep440_version to handle stable (post) release versions

refactor get_highest_version() to use gen_pep440_version()

add test to verify packaging.version.parse() compatibility of gen_pep440_version output

remove redundant f-string specifiers

add test to show that Patcher.__init__ messes up the current version.

move command line version check from utils.builder to cli.options and use packaging.version, with tests

add some typing for version string arguments, to prevent confusion

Merge branch 'issue299' into drop-dsdev-version

implement Package.channel as property, using packaging Version instead of dsdev-utils Version

fix cli app_version test

move VALID_CHANNELS from cli.options to settings, to prevent circular imports (and it's more obvious)

assign parts only after checking for TypeError, and fix Package tests

add todo notes for next release (backward incompatible changes)

remove parse_platform, as it has been replaced by parse_archive_name

rename PackageHandler private methods for consistency

add a LATEST_KEY for consistency

create a VersionShim class in utils, replacing the version functions from client.updates

use packaging Version in PackageHandler, instead of dsdev_utils Version, and add test

rename Patch._json_data to _version_data, for consistency

rename json_data variables in PackageHandler to version_data, for consistency

consistently use LATEST_KEY and UPDATES_KEY

rename remaining json_data variables and attributes to version_data, for consistency

rename VersionShim to PyuVersion, clarify docstrings, use PyuVersion instead of packaging.version.Version etc.

check log output in patcher tests, to ensure Patcher.start returns False for the right reason.

use pyu_format in hash_key (forgot that one..)

replace dsdev_utils.helpers.gzip_decompress by a local implementation that calls gzip.decompress() directly

move get_highest_version() to client/__init__.py, and add latest_version to initial LibUpdate data

check prerelease status in _get_required_patches

remove Patcher._calc_diff(), for clarity

update name of PyuVersion test

Merge branch 'main' into issue315

Merge branch 'issue299' into multifix

Merge branch 'issue304' into multifix

Merge branch 'issue306' into multifix

Merge branch 'issue315' into multifix

fix test_make_archive

codecov · 2022-01-05T01:56:28Z

Codecov Report

Merging #322 (6e79a0c) into main (7093d76) will increase coverage by 0.27%.
The diff coverage is 93.06%.

❗ Current head 6e79a0c differs from pull request most recent head 1353b55. Consider uploading reports for the commit 1353b55 to get more accurate results

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   88.14%   88.41%   +0.27%     
==========================================
  Files          26       26              
  Lines        2336     2314      -22     
==========================================
- Hits         2059     2046      -13     
+ Misses        277      268       -9

Impacted Files	Coverage Δ
pyupdater/client/__init__.py	`89.17% <88.88%> (+0.80%)`	⬆️
pyupdater/core/package_handler/package.py	`80.00% <89.65%> (-2.45%)`	⬇️
pyupdater/client/patcher.py	`83.58% <90.47%> (+0.90%)`	⬆️
pyupdater/client/updates.py	`87.19% <92.30%> (-3.00%)`	⬇️
pyupdater/core/package_handler/__init__.py	`92.66% <92.30%> (+1.45%)`	⬆️
pyupdater/cli/options.py	`100.00% <100.00%> (ø)`
pyupdater/core/key_handler/keys.py	`83.17% <100.00%> (ø)`
pyupdater/core/package_handler/patch.py	`86.79% <100.00%> (ø)`
pyupdater/settings.py	`100.00% <100.00%> (ø)`
pyupdater/utils/__init__.py	`86.79% <100.00%> (+1.74%)`	⬆️
... and 5 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

handle platform in test_make_archive

use single source for valid channels in Client._update_check

fix typo in test_make_archive

use latest os runners for github

dennisvang · 2022-03-22T15:47:02Z

@JMSwag Is there anything I can do to get this PR approved?

its-monotype · 2022-09-24T20:00:52Z

When Pyupdater 5?

its-monotype · 2022-09-25T13:33:08Z

@JMSwag When PR will be approved??? We can't use Pyupdater without this fixes from this amazing guy

dennisvang added 30 commits December 6, 2021 17:11

raise IOError when trying to decompress None

cefbed6

issue304:

328cc8c

catch FileNotFoundError, due to missing manifest, in utils.make_archive()

issue304:

d1a05e2

add test for utils.make_archive(), reproducing issue 304

issue299:

794c47f

fix Package.name_regex

issue299:

6233d78

introduce a parse_archive_name function, with tests

issue299:

7809fac

use parse_archive_name to fix Package.extract_info removed Package._parse_package_name, now unused

issue315:

013d0cb

cherry-pick VALID_CHANNELS from bce7d36 (issue311)

issue315:

0e7e7bf

introduce a gen_pep440_version(), similar to gen_user_friendly_version, with tests

issue315:

d3f3983

refactor gen_pep440_version to handle stable (post) release versions

issue315:

65c5d92

refactor get_highest_version() to use gen_pep440_version()

issue315:

4df91db

add test to verify packaging.version.parse() compatibility of gen_pep440_version output

issue315:

414a97e

remove redundant f-string specifiers

issue315:

fe3bad6

add test to show that Patcher.__init__ messes up the current version.

drop-dsdev-version:

75e2294

move command line version check from utils.builder to cli.options and use packaging.version, with tests

drop-dsdev-version:

fda57e2

add some typing for version string arguments, to prevent confusion

drop-dsdev-version:

7663f16

Merge branch 'issue299' into drop-dsdev-version

drop-dsdev-version:

961cb79

implement Package.channel as property, using packaging Version instead of dsdev-utils Version

drop-dsdev-version:

e26985d

fix cli app_version test

drop-dsdev-version:

4c196e5

move VALID_CHANNELS from cli.options to settings, to prevent circular imports (and it's more obvious)

drop-dsdev-version:

de36b58

assign parts only after checking for TypeError, and fix Package tests

drop-dsdev-version:

0fc92a6

add todo notes for next release (backward incompatible changes)

drop-dsdev-version:

47dbd29

remove parse_platform, as it has been replaced by parse_archive_name

drop-dsdev-version:

c830bc9

rename PackageHandler private methods for consistency

drop-dsdev-version:

e6470df

add a LATEST_KEY for consistency

drop-dsdev-version:

e7ad90e

create a VersionShim class in utils, replacing the version functions from client.updates

drop-dsdev-version:

9e4a466

use packaging Version in PackageHandler, instead of dsdev_utils Version, and add test

drop-dsdev-version:

afe7e92

rename Patch._json_data to _version_data, for consistency

drop-dsdev-version:

f697b1d

rename json_data variables in PackageHandler to version_data, for consistency

drop-dsdev-version:

41493d8

consistently use LATEST_KEY and UPDATES_KEY

drop-dsdev-version:

142da33

rename remaining json_data variables and attributes to version_data, for consistency

dennisvang added 14 commits December 30, 2021 23:00

drop-dsdev-version:

63390af

rename VersionShim to PyuVersion, clarify docstrings, use PyuVersion instead of packaging.version.Version etc.

drop-dsdev-version:

4b985db

check log output in patcher tests, to ensure Patcher.start returns False for the right reason.

issue315:

3f29fe0

use pyu_format in hash_key (forgot that one..)

issue306:

155976f

replace dsdev_utils.helpers.gzip_decompress by a local implementation that calls gzip.decompress() directly

issue315:

2894848

move get_highest_version() to client/__init__.py, and add latest_version to initial LibUpdate data

issue315:

d6709f4

check prerelease status in _get_required_patches

issue315:

f93da45

remove Patcher._calc_diff(), for clarity

issue315:

88c977b

update name of PyuVersion test

issue315:

bdd865f

Merge branch 'main' into issue315

multifix:

a786f4d

Merge branch 'issue299' into multifix

multifix:

1418b3b

Merge branch 'issue304' into multifix

multifix:

be62102

Merge branch 'issue306' into multifix

multifix:

b704cbc

Merge branch 'issue315' into multifix

multifix:

39831ff

fix test_make_archive

dennisvang mentioned this pull request Jan 5, 2022

Fix issue 311: add an 'undo' command #312

Closed

dennisvang added 3 commits January 5, 2022 10:11

multifix:

e81e340

handle platform in test_make_archive

multifix:

fa7954e

use single source for valid channels in Client._update_check

multifix:

6e79a0c

fix typo in test_make_archive

dennisvang mentioned this pull request Mar 21, 2022

Project Update v5 - Clean Slate #320

Closed

multifix:

1353b55

use latest os runners for github

dennisvang mentioned this pull request May 13, 2022

'LegacyVersion' object has no attribute 'major' #299

Closed

JMSwag closed this Sep 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix multiple issues related to release 4.0 #322

Fix multiple issues related to release 4.0 #322

dennisvang commented Jan 4, 2022 •

edited

Loading

codecov bot commented Jan 5, 2022 •

edited

Loading

dennisvang commented Mar 22, 2022

its-monotype commented Sep 24, 2022

its-monotype commented Sep 25, 2022 •

edited

Loading

Fix multiple issues related to release 4.0 #322

Fix multiple issues related to release 4.0 #322

Conversation

dennisvang commented Jan 4, 2022 • edited Loading

codecov bot commented Jan 5, 2022 • edited Loading

Codecov Report

dennisvang commented Mar 22, 2022

its-monotype commented Sep 24, 2022

its-monotype commented Sep 25, 2022 • edited Loading

dennisvang commented Jan 4, 2022 •

edited

Loading

codecov bot commented Jan 5, 2022 •

edited

Loading

its-monotype commented Sep 25, 2022 •

edited

Loading