Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better option for password resetting #501

Closed
alexlittle opened this issue Jun 12, 2018 · 4 comments
Closed

Better option for password resetting #501

alexlittle opened this issue Jun 12, 2018 · 4 comments
Assignees
Labels
enhancement good-first-issue Issues that are suitable for new contributors medium priority

Comments

@alexlittle
Copy link
Member

alexlittle commented Jun 12, 2018

Currently the password reset works by resetting the password immediately to a new random 8-char string and emailing this to the user. So even if they then remember the old password it won't work.

A better option would be for this to function as many other sites do for password resetting, so a (time limited) link is sent by email to reset the password and forces the user to enter a new password (removing the 'temp password' as now), but in the meantime they can still use their original password if they remember it.

Very likely there will be django plugins that will handle this - just needs some investigation and testing as to the best option

@studiosi
Copy link

OWASP has a fine resource of the best strategies to reset the password (for reference).

https://www.owasp.org/index.php/Forgot_Password_Cheat_Sheet

@alexlittle alexlittle added the good-first-issue Issues that are suitable for new contributors label Dec 9, 2018
@alexlittle
Copy link
Member Author

This might be a good start: https://django-password-reset.readthedocs.io/en/latest/index.html (also: https://github.com/brutasse/django-password-reset for the code). Doesn;t do everything (like security questions etc) but likely good enough for now (and better than what we currently do)

@alexlittle
Copy link
Member Author

Use the built in django auth method for doing this

@alexlittle alexlittle changed the title Investigate better options for password resetting Better option for password resetting Apr 25, 2019
@alexlittle
Copy link
Member Author

transferred to OPPIA-42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good-first-issue Issues that are suitable for new contributors medium priority
Projects
None yet
Development

No branches or pull requests

3 participants