Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove signup_callback function #605

Closed
alexlittle opened this issue Apr 9, 2019 · 3 comments
Closed

Remove signup_callback function #605

alexlittle opened this issue Apr 9, 2019 · 3 comments
Labels
enhancement good-first-issue Issues that are suitable for new contributors medium priority refectoring/review Any areas of code that could be improved/refactored

Comments

@alexlittle
Copy link
Member

It basically doesn't do anything now, see: https://sonarcloud.io/project/issues?id=django_oppia&open=AWmaBEIa5QE9aC-CyjZm&resolved=false&types=CODE_SMELL and https://github.com/DigitalCampus/django-oppia/blob/0.11.1/oppia/signals.py
@alexlittle alexlittle added enhancement medium priority refectoring/review Any areas of code that could be improved/refactored good-first-issue Issues that are suitable for new contributors labels Apr 9, 2019
@PiyushSaravagi
Copy link

Hey Alex, I've never contributed to open-source projects. Would love to start here. Is this issue still open?

@alexlittle
Copy link
Member Author

Hi - that would be great, and yes this issue is still open. It might be best to make the change on the 0.12.0 branch of the server, as we'll be releasing that soon, but no problem if you'd prefer to make the change on the current master branch. Just let us know if you get stuck anywhere with this... also we have our community forum site at: https://community.oppia-mobile.org/

@PiyushSaravagi
Copy link

Awesome! Will get this done and keep you updated. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good-first-issue Issues that are suitable for new contributors medium priority refectoring/review Any areas of code that could be improved/refactored
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexlittle @PiyushSaravagi