add loggers instead of e.printStackTrace - #777

DigitalCampus · Feb 7, 2019 · 19b2ac6 · 19b2ac6
1 parent 9b56c7a
commit 19b2ac6
Show file tree

Hide file tree

Showing 39 changed files with 210 additions and 94 deletions.
diff --git a/app/src/main/java/org/digitalcampus/oppia/activity/TagSelectActivity.java b/app/src/main/java/org/digitalcampus/oppia/activity/TagSelectActivity.java
@@ -182,7 +182,7 @@ public Boolean call() throws Exception {
 				refreshTagList();
 			} catch (JSONException e) {
 				Mint.logException(e);
-				e.printStackTrace();
+                Log.d(TAG, "Error conencting to server: ", e);
 				UIUtils.showAlert(this, R.string.loading, R.string.error_connection, finishActivity);
 			}
 		} else {

diff --git a/app/src/main/java/org/digitalcampus/oppia/di/AppModule.java b/app/src/main/java/org/digitalcampus/oppia/di/AppModule.java
@@ -3,6 +3,9 @@
 import android.app.Application;
 import android.content.SharedPreferences;
 import android.preference.PreferenceManager;
+import android.util.Log;
+
+import com.splunk.mint.Mint;
 
 import org.digitalcampus.oppia.application.DbHelper;
 import org.digitalcampus.oppia.application.SessionManager;
@@ -27,6 +30,8 @@
 @Module
 public class AppModule {
 
+    public static final String TAG = AppModule.class.getSimpleName();
+
     private Application app;
 
     public AppModule(Application app){
@@ -57,7 +62,8 @@ public User provideUser(){
         try {
             return DbHelper.getInstance(app).getUser(SessionManager.getUsername(app));
         } catch (UserNotFoundException e) {
-            e.printStackTrace();
+            Mint.logException(e);
+            Log.d(TAG, "User not found: ", e);
         }
         return null;
     }

diff --git a/app/src/main/java/org/digitalcampus/oppia/fragments/AboutFragment.java b/app/src/main/java/org/digitalcampus/oppia/fragments/AboutFragment.java
@@ -30,6 +30,7 @@
 import android.os.Bundle;
 import android.preference.PreferenceManager;
 import android.support.v4.app.Fragment;
+import android.util.Log;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
@@ -80,7 +81,7 @@ public void onActivityCreated(Bundle savedInstanceState) {
 			versionNo.setText(getString(R.string.version,no));
 		} catch (NameNotFoundException e) {
 			Mint.logException(e);
-			e.printStackTrace();
+			Log.d(TAG, "Error getting version name: ", e);
 		}
 	}
 }
diff --git a/app/src/main/java/org/digitalcampus/oppia/fragments/BadgesFragment.java b/app/src/main/java/org/digitalcampus/oppia/fragments/BadgesFragment.java
@@ -111,7 +111,8 @@ private void refreshBadgesList() {
 			tv.setVisibility(View.GONE);
             badgesAdapter.notifyDataSetChanged();
 		} catch (Exception e) {
-			e.printStackTrace();
+			Mint.logException(e);
+			Log.d(TAG, "Error refreshing badges list: ", e);
 		}
 
 	}
@@ -129,7 +130,7 @@ public void apiRequestComplete(Payload response) {
 			} catch (JSONException e) {
 				Mint.logException(e);
 				UIUtils.showAlert(super.getActivity(), R.string.loading, R.string.error_connection);
-				e.printStackTrace();
+				Log.d(TAG, "Error connecting to server: ", e);
 			}
 		} else {
 			TextView tv = (TextView) this.getView().findViewById(R.id.fragment_badges_title);

diff --git a/app/src/main/java/org/digitalcampus/oppia/gamification/GamificationService.java b/app/src/main/java/org/digitalcampus/oppia/gamification/GamificationService.java
@@ -6,6 +6,8 @@
 import android.preference.PreferenceManager;
 import android.util.Log;
 
+import com.splunk.mint.Mint;
+
 import org.digitalcampus.mobile.quiz.Quiz;
 import org.digitalcampus.oppia.activity.PrefsActivity;
 import org.digitalcampus.oppia.application.DbHelper;
@@ -179,7 +181,8 @@ else if (SERVICE_EVENT_MEDIAPLAYBACK.equals(eventName)){
                 }
             }
         } catch (JSONException e) {
-            e.printStackTrace();
+            Mint.logException(e);
+            Log.d(TAG, "JSON error: ", e);
         }
     }
 

diff --git a/app/src/main/java/org/digitalcampus/oppia/model/Activity.java b/app/src/main/java/org/digitalcampus/oppia/model/Activity.java
@@ -32,6 +32,9 @@
 
 import android.content.res.Resources;
 import android.graphics.drawable.BitmapDrawable;
+import android.util.Log;
+
+import com.splunk.mint.Mint;
 
 public class Activity implements Serializable{
 
@@ -188,7 +191,8 @@ public void setContentFromJSONString(String json){
 				}
 			}
 		} catch (JSONException e) {
-			e.printStackTrace();
+			Mint.logException(e);
+			Log.d(TAG, "JSON error: ", e);
 		}
 	}
 	public boolean hasMedia(){

diff --git a/app/src/main/java/org/digitalcampus/oppia/model/CompleteCourseProvider.java b/app/src/main/java/org/digitalcampus/oppia/model/CompleteCourseProvider.java
@@ -1,6 +1,9 @@
 package org.digitalcampus.oppia.model;
 
 import android.content.Context;
+import android.util.Log;
+
+import com.splunk.mint.Mint;
 
 import org.digitalcampus.mobile.learning.R;
 import org.digitalcampus.oppia.activity.CourseIndexActivity;
@@ -15,13 +18,16 @@
 
 public class CompleteCourseProvider {
 
+    public static final String TAG = CompleteCourseProvider.class.getSimpleName();
+
     public CompleteCourse getCompleteCourseSync(Context ctx, Course course){
         try {
             CourseXMLReader cxr = new CourseXMLReader(course.getCourseXMLLocation(), course.getCourseId(), ctx);
             cxr.parse(CourseXMLReader.ParseMode.COMPLETE);
             return cxr.getParsedCourse();
         } catch (InvalidXMLException e) {
-            e.printStackTrace();
+            Mint.logException(e);
+            Log.d(TAG, "Error loading course XML: ", e);
             showErrorMessage(ctx);
             return null;
         }

diff --git a/app/src/main/java/org/digitalcampus/oppia/model/MultiLangInfo.java b/app/src/main/java/org/digitalcampus/oppia/model/MultiLangInfo.java
@@ -17,6 +17,10 @@
 
 package org.digitalcampus.oppia.model;
 
+import android.util.Log;
+
+import com.splunk.mint.Mint;
+
 import org.json.JSONArray;
 import org.json.JSONException;
 import org.json.JSONObject;
@@ -28,6 +32,8 @@
 
 public class MultiLangInfo implements Serializable {
 
+    public static final String TAG = MultiLangInfo.class.getSimpleName();
+
     private ArrayList<Lang> langs = new ArrayList<>();
     private ArrayList<Lang> titles = new ArrayList<>();
     private ArrayList<Lang> descriptions = new ArrayList<>();
@@ -103,7 +109,8 @@ private String getInfoJSONString(ArrayList<Lang> values){
             try {
                 obj.put(l.getLang(), l.getContent());
             } catch (JSONException e) {
-                e.printStackTrace();
+                Mint.logException(e);
+                Log.d(TAG, "JSON error: ", e);
             }
             array.put(obj);
         }
@@ -128,9 +135,11 @@ private void setInfoFromJSONString(String jsonStr, ArrayList<Lang> values, boole
                 }
             }
         } catch (JSONException e) {
-            e.printStackTrace();
+            Mint.logException(e);
+            Log.d(TAG, "JSON error: ", e);
         } catch (NullPointerException npe){
-            npe.printStackTrace();
+            Mint.logException(npe);
+            Log.d(TAG, "Null pointer error: ", npe);
         }
     }
 }
diff --git a/app/src/main/java/org/digitalcampus/oppia/service/TrackerService.java b/app/src/main/java/org/digitalcampus/oppia/service/TrackerService.java
@@ -197,7 +197,8 @@ public void apiRequestComplete(Payload response) {
 			}
 
 		} catch (JSONException e) {
-			e.printStackTrace();
+			Mint.logException(e);
+			Log.d(TAG, "JSON error: ", e);
 		} 
 
 		if(updateAvailable){

diff --git a/app/src/main/java/org/digitalcampus/oppia/service/bluetooth/BluetoothTransferService.java b/app/src/main/java/org/digitalcampus/oppia/service/bluetooth/BluetoothTransferService.java
@@ -11,6 +11,8 @@
 import android.support.annotation.Nullable;
 import android.util.Log;
 
+import com.splunk.mint.Mint;
+
 import org.digitalcampus.mobile.learning.R;
 import org.digitalcampus.oppia.model.CourseTransferableFile;
 import org.digitalcampus.oppia.utils.storage.FileUtils;
@@ -316,7 +318,8 @@ public void sendFile(CourseTransferableFile trFile){
             tasksDownloading.remove(trFile);
 
         } catch (IOException e) {
-            e.printStackTrace();
+            Mint.logException(e);
+            Log.d(TAG, "IO exception: ", e);
         }
     }
 

diff --git a/app/src/main/java/org/digitalcampus/oppia/service/courseinstall/CourseInstall.java b/app/src/main/java/org/digitalcampus/oppia/service/courseinstall/CourseInstall.java
@@ -22,6 +22,8 @@
 import android.preference.PreferenceManager;
 import android.util.Log;
 
+import com.splunk.mint.Mint;
+
 import org.digitalcampus.mobile.learning.R;
 import org.digitalcampus.oppia.activity.PrefsActivity;
 import org.digitalcampus.oppia.application.DbHelper;
@@ -83,8 +85,8 @@ public static void installDownloadedCourse(Context ctx, String filename, String
             courseDir = tempdir.list()[0]; // use this to get the course name
         } catch (ArrayIndexOutOfBoundsException aioobe) {
             FileUtils.cleanUp(tempdir, Storage.getDownloadPath(ctx) + filename);
-            aioobe.printStackTrace();
-            Log.d(TAG, "Error: " + aioobe.getMessage());
+            Mint.logException(aioobe);
+            Log.d(TAG, "Error: ", aioobe);
             listener.onError(ctx.getString(R.string.error_installing_course, shortname));
             return;
         }
@@ -100,8 +102,8 @@ public static void installDownloadedCourse(Context ctx, String filename, String
             courseTrackerXMLPath = tempdir + File.separator + courseDir + File.separator + MobileLearning.COURSE_TRACKER_XML;
         } catch (ArrayIndexOutOfBoundsException aioobe){
             FileUtils.cleanUp(tempdir, Storage.getDownloadPath(ctx) + filename);
-            aioobe.printStackTrace();
-            Log.d(TAG, "Error: " + aioobe.getMessage());
+            Mint.logException(aioobe);
+            Log.d(TAG, "Error: ", aioobe);
             listener.onError(ctx.getString(R.string.error_media_download));
             return;
         }
@@ -154,7 +156,8 @@ public static void installDownloadedCourse(Context ctx, String filename, String
                 org.apache.commons.io.FileUtils.copyDirectory(src, new File(dest, src.getName()));
                 success = true;
             } catch (IOException e) {
-                e.printStackTrace();
+                Mint.logException(e);
+                Log.d(TAG, "Error copying course: ", e);
                 listener.onFail(ctx.getString(R.string.error_installing_course, title));
                 return;
             }

diff --git a/app/src/main/java/org/digitalcampus/oppia/service/courseinstall/CourseIntallerService.java b/app/src/main/java/org/digitalcampus/oppia/service/courseinstall/CourseIntallerService.java
@@ -416,7 +416,7 @@ private boolean updateCourseSchedule(String scheduleUrl, String shortname){
 
         } catch (JSONException e) {
             Mint.logException(e);
-            e.printStackTrace();
+            Log.d(TAG, "JSON error: ", e);
             sendBroadcast(scheduleUrl, ACTION_FAILED, getString(R.string.error_processing_response));
             removeDownloading(scheduleUrl);
         } catch (UserNotFoundException | IOException e) {

diff --git a/app/src/main/java/org/digitalcampus/oppia/task/APIUserRequestTask.java b/app/src/main/java/org/digitalcampus/oppia/task/APIUserRequestTask.java
@@ -31,6 +31,8 @@
 import android.content.Context;
 import android.util.Log;
 
+import com.splunk.mint.Mint;
+
 import okhttp3.OkHttpClient;
 import okhttp3.Request;
 import okhttp3.Response;
@@ -74,7 +76,8 @@ protected Payload doInBackground(Payload... params){
             }
 
 		}  catch (IOException e) {
-			e.printStackTrace();
+            Mint.logException(e);
+            Log.d(TAG, "IO exception", e);
 			payload.setResult(false);
 			payload.setResultResponse(ctx.getString(R.string.error_connection));
 		}

diff --git a/app/src/main/java/org/digitalcampus/oppia/task/ChangeStorageOptionTask.java b/app/src/main/java/org/digitalcampus/oppia/task/ChangeStorageOptionTask.java
@@ -23,6 +23,8 @@
 import android.preference.PreferenceManager;
 import android.util.Log;
 
+import com.splunk.mint.Mint;
+
 import org.digitalcampus.mobile.learning.R;
 import org.digitalcampus.oppia.activity.PrefsActivity;
 import org.digitalcampus.oppia.listener.MoveStorageListener;
@@ -142,8 +144,8 @@ private boolean copyDirectory(String sourcePath, String destPath){
             FileUtils.deleteDir(source);
             Log.d(TAG,"Copying " + sourcePath + " completed");
         } catch (IOException e) {
-            Log.d(TAG,"Copying " + sourcePath + " to " + destPath + " failed");
-            e.printStackTrace();
+            Mint.logException(e);
+            Log.d(TAG, "Copying " + sourcePath + " to " + destPath + " failed", e);
             return false;
         }
         return true;

diff --git a/app/src/main/java/org/digitalcampus/oppia/task/ExportActivityTask.java b/app/src/main/java/org/digitalcampus/oppia/task/ExportActivityTask.java
@@ -7,6 +7,8 @@
 import android.text.TextUtils;
 import android.util.Log;
 
+import com.splunk.mint.Mint;
+
 import org.digitalcampus.oppia.activity.PrefsActivity;
 import org.digitalcampus.oppia.application.DbHelper;
 import org.digitalcampus.oppia.listener.ExportActivityListener;
@@ -29,7 +31,7 @@
 
 public class ExportActivityTask extends AsyncTask<Payload, Integer, String> {
 
-    private static final String TAG = ExportActivityTask.class.getSimpleName();;
+    private static final String TAG = ExportActivityTask.class.getSimpleName();
     protected Context ctx;
     private SharedPreferences prefs;
     private ExportActivityListener listener;
@@ -106,9 +108,11 @@ protected String doInBackground(Payload... payloads) {
             out = new OutputStreamWriter(f);
             out.write(json);
         } catch (FileNotFoundException e) {
-            e.printStackTrace();
+            Mint.logException(e);
+            Log.d(TAG, "FileNotFoundException: ", e);
         } catch (IOException e) {
-            e.printStackTrace();
+            Mint.logException(e);
+            Log.d(TAG, "IO exception: ", e);
         } finally {
             if (out != null){
                 try {

diff --git a/app/src/main/java/org/digitalcampus/oppia/task/ImportLeaderboardsTask.java b/app/src/main/java/org/digitalcampus/oppia/task/ImportLeaderboardsTask.java
@@ -4,6 +4,8 @@
 import android.os.AsyncTask;
 import android.util.Log;
 
+import com.splunk.mint.Mint;
+
 import org.digitalcampus.mobile.learning.R;
 import org.digitalcampus.oppia.application.DbHelper;
 import org.digitalcampus.oppia.application.MobileLearning;
@@ -29,13 +31,13 @@
 public class ImportLeaderboardsTask extends AsyncTask<Payload, DownloadProgress, Payload> {
 
 
+    private static final String TAG = ImportLeaderboardsTask.class.getSimpleName();
+
     public interface ImportLeaderboardListener {
         void onLeaderboardImportProgress(String message);
         void onLeaderboardImportComplete(Boolean success, String message);
     }
 
-
-    public final static String TAG = ImportLeaderboardsTask.class.getSimpleName();
     private Context ctx;
 
 
@@ -65,13 +67,17 @@ protected Payload doInBackground(Payload... params) {
                         String json = FileUtils.readFile(json_file);
                         updatedPositions += Leaderboard.importLeaderboardJSON(ctx, json);
                     } catch (IOException e) {
-                        e.printStackTrace();
+                        Mint.logException(e);
+                        Log.d(TAG, "IOException: ", e);
                     } catch (ParseException e) {
-                        e.printStackTrace();
+                        Mint.logException(e);
+                        Log.d(TAG, "ParseException: ", e);
                     } catch (JSONException e) {
-                        e.printStackTrace();
+                        Mint.logException(e);
+                        Log.d(TAG, "JSONException: ", e);
                     } catch (WrongServerException e) {
-                        e.printStackTrace();
+                        Mint.logException(e);
+                        Log.d(TAG, "WrongServerException: ", e);
                     }
 
                     FileUtils.deleteFile(json_file);