Feature/228 follow users projects #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed user model tho have UserProject object.
Changed previous commit because there was an error with duplicate ids
…rResource result UserFollowedProject class is meant for linking tables
…m/DigitalExcellence/dex-backend into feature/228-follow-users-projects
Changed names to be in line with naming convention.
This commit makes it possible to follow other users. This commit includes the model,repository,service,dbset needed for following a user. Co-Authored-By: Dave Bouman <49709450+DaveBouman@users.noreply.github.com>
Added inversed props for linking table
niraymak
requested changes
Oct 6, 2020
There was a problem hiding this comment.
Thanks for your pull request.
Please change endpoints so they return ResourceResults. Then also add Postman tests for removing follow, now after one iteration Postman tests do not work anymore because you'll get HTTPstatus 409 You are already following this user.
I also think the FollowProject endpoints should be in the ProjectController.
Please also look into the migration because I think something is wrong.
Closed
In resources changed using models to using resources instead. Moved following projects from user controller to project controller. Added comments and got rid of all warnings. Co-Authored-By: Dave Bouman <49709450+DaveBouman@users.noreply.github.com>
|
Since #240 is now merged, make sure the documentation is updated! |
…m/DigitalExcellence/dex-backend into feature/228-follow-users-projects
…s' into feature/228-follow-users-projects
…-projects' into feature/228-follow-users-projects" This reverts commit b018704.
niraymak
requested changes
Oct 21, 2020
added 3 commits
October 26, 2020 16:14
…instead of random names which fail.
… uses the id's instead of the names since they can be different and can not be tested.
|
XML conflicts have been resolved. Also Postman now uses Id's instead of names so tests are run everywhere correct now. |
…m/DigitalExcellence/dex-backend into feature/228-follow-users-projects
niraymak
previously approved these changes
Oct 30, 2020
niraymak
approved these changes
Nov 4, 2020
Brend-Smits
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ability to follow users and projects.
Type of change
Checklist
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.
Everything happens in User Controller, pass in the ID of the project or user you want to follow, this is not the id of logged in user.
Login in and do a post to user/follow/user/{userId}
Unfollow the user with a delete method.
Follow a project user/follow/project/{projectId}
Unfollow the project
Link to issue
Closes: #issuenumber