-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature#438 transfer project ownership #506
Conversation
Email client is temp untill RabbitMQ emailSender has been fixed.
…ltiple times to change status
…entity not attached to transfer request
@MeesvanStraten I keep getting "Transfer could not be initiated" response. Should we look at it together tomorrow? As I think it's something on my side |
@MeesvanStraten I got the same "transfer could not be initiated" response. |
@1SvenHansen @BartvanEijkelenburg Yea we can have a look if you have time available. Sent me a message on teams. Maybe we can sit with three at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked it all, Looks good.
One thing what would be great to be added (saw it as a ToDo aswell), to notify the owner when the transfership was declined and notify the owner when the project has been transferd.
When I transfer a project only the accepting user knows whether it was succesfull or not.
@BartvanEijkelenburg Will add that today yeah. |
@1SvenHansen @BartvanEijkelenburg @DaveBouman I added an email where the succesfull transfer is communicated with both users (old and new). Also I added an email where the current owner is notified when the potential new user denies the request. |
…ceptions >1 result
…to Feature#438TransferProjectOwnership
Look good! But I miss a concrete way to cancel the transfer of a project owner when the old owner has initiated the transfer but the new owner has not yet accepted. What if I change my mind or the new owner does not respond how can I rectract he transfer process after accepting it on my part. |
Description
You will need two accounts to test this PR. 1 account to initiate the project transfer from and the second one to take the ownership. You also will need 2 email accounts, So you could use your FHICT email and a personal mail etc.
You can change an email adress of a DeX user in the User table.
Also you will need to set envoirement variables for the sendgrid api key and the dex email account. You will find the name of the variables in the MailClient.cs class and the values you can ask me for or view our pass manager.
Make sure that your two email accounts are present in the database and that it does not show !!
Type of change
Checklist
Steps to Test or Reproduce
Link to issue
Closes: #438