Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature#438 transfer project ownership #506

Merged
merged 38 commits into from
Oct 5, 2021

Conversation

MeesvanStraten
Copy link
Contributor

@MeesvanStraten MeesvanStraten commented Sep 27, 2021

Description

You will need two accounts to test this PR. 1 account to initiate the project transfer from and the second one to take the ownership. You also will need 2 email accounts, So you could use your FHICT email and a personal mail etc.
You can change an email adress of a DeX user in the User table.

Also you will need to set envoirement variables for the sendgrid api key and the dex email account. You will find the name of the variables in the MailClient.cs class and the values you can ask me for or view our pass manager.
Make sure that your two email accounts are present in the database and that it does not show !!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

  1. Login as a user and check that you have a project.
  2. Via SwaggerUI go to the /api/Project/transfer/{projectId} endpoint and enter the email address for the new project owner combined with the projectId. The email adress should belong to a DeX user. You can change the email address in the database. Or more easy use two different FHICT accounts.
  3. You should have an email indicating the project transfer. Accept or Deny. Please test all possible outcomes.
  4. After accepting the transfer, the new user should also receive an email (this is the email address you entered, this also must be a DeX user!!)
  5. After accepting the second email verification the project should now be transferred to the new user.

Link to issue

Closes: #438

@HansenSven
Copy link
Contributor

@MeesvanStraten I keep getting "Transfer could not be initiated" response. Should we look at it together tomorrow? As I think it's something on my side

@BartvanEijkelenburg
Copy link
Contributor

@MeesvanStraten I got the same "transfer could not be initiated" response.

@MeesvanStraten
Copy link
Contributor Author

@1SvenHansen @BartvanEijkelenburg Yea we can have a look if you have time available. Sent me a message on teams. Maybe we can sit with three at the same time.

Copy link
Contributor

@BartvanEijkelenburg BartvanEijkelenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it all, Looks good.

One thing what would be great to be added (saw it as a ToDo aswell), to notify the owner when the transfership was declined and notify the owner when the project has been transferd.

When I transfer a project only the accepting user knows whether it was succesfull or not.

@MeesvanStraten
Copy link
Contributor Author

@BartvanEijkelenburg Will add that today yeah.

@MeesvanStraten
Copy link
Contributor Author

@1SvenHansen @BartvanEijkelenburg @DaveBouman I added an email where the succesfull transfer is communicated with both users (old and new). Also I added an email where the current owner is notified when the potential new user denies the request.

@DaveBouman
Copy link
Contributor

Look good! But I miss a concrete way to cancel the transfer of a project owner when the old owner has initiated the transfer but the new owner has not yet accepted. What if I change my mind or the new owner does not respond how can I rectract he transfer process after accepting it on my part.

@MeesvanStraten MeesvanStraten added the Hacktoberfest Label for the hacktoberfest label Oct 4, 2021
@MeesvanStraten MeesvanStraten marked this pull request as ready for review October 4, 2021 13:23
@MeesvanStraten MeesvanStraten merged commit 4bb4c56 into develop Oct 5, 2021
@MeesvanStraten MeesvanStraten deleted the Feature#438TransferProjectOwnership branch October 5, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Label for the hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEEDS MORE INFORMATION] Transfer ownership project
4 participants