Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock, Folder Update and Fixs #25

Merged
merged 19 commits into from
Dec 5, 2022
Merged

Clock, Folder Update and Fixs #25

merged 19 commits into from
Dec 5, 2022

Conversation

VitoBarra
Copy link
Contributor

@VitoBarra VitoBarra commented Aug 8, 2022

implemented the clock chip that everyone wanted with fully support to Hz change

also added new feature regarding folders:

  • renaming folder
  • deleting folder
  • moving chips between folders
  • added a special folder to handle compatibility and chip without a valid folder

Reworked the focus system used to handle interaction, now adding a new key-binding option should be easier

A smal change to enhanced UX during editing a chip. now you can see the name the chip you are currently working on

issue #28, #34, #36 Fixed

issue #31 Fixed. it is a work around but it works pretty well so

issue #32 Fixed, this was an enormous debug work; in the end I found out the issue was caused by a single line of code: line 62 of the ChipPackage class. I commented the line and it looks like everything is still working properly.

issue #33 Fixed. I think I fixed this issue some time ago while I was working on updating compatibility. I ran some tests and it seems to be working for me however I think this needs further testing to assure it works for everyone.

@AOx0 AOx0 self-requested a review August 17, 2022 20:39
@AOx0 AOx0 added the enhancement New feature or request label Aug 17, 2022
@VitoBarra VitoBarra changed the title Clock and Folder Update Clock, Folder Update and Fixs Sep 13, 2022
@RobMayer
Copy link

hate to be that guy, but is there any word on if/when this will get folded in?

@crispeeweevile
Copy link

hate to be that guy, but is there any word on if/when this will get folded in?

Dude, I don't blame you, I've been waiting for a while too. One thing to note is that there are still some bugs in this update, do they should be ironed out first, but you can totally download it and compile it to try it out yourself.

@RobMayer
Copy link

hate to be that guy, but is there any word on if/when this will get folded in?

Dude, I don't blame you, I've been waiting for a while too. One thing to note is that there are still some bugs in this update, do they should be ironed out first, but you can totally download it and compile it to try it out yourself.

totally could, and I may yet - I'm just not accustomed to unity in the slightest.

@crispeeweevile
Copy link

hate to be that guy, but is there any word on if/when this will get folded in?

Dude, I don't blame you, I've been waiting for a while too. One thing to note is that there are still some bugs in this update, do they should be ironed out first, but you can totally download it and compile it to try it out yourself.

totally could, and I may yet - I'm just not accustomed to unity in the slightest.

Haha, yeah me neither, it's actually because of this project that I (very) recently started learning a little unity, thankfully just compiling this edition of the game wasn't too hard.

@AOx0
Copy link
Collaborator

AOx0 commented Oct 24, 2022

Haha, yeah me neither, it's actually because of this project that I (very) recently started learning a little unity, thankfully just compiling this edition of the game wasn't too hard.

Ahh, the beauty of open source.

hate to be that guy, but is there any word on if/when this will get folded in?

The thing is, I have a 128 GB laptop so downloading Unity and keeping it on my device becomes a nightmare when my average free storage is ~5GB, I have to literally uninstall every program I use on a daily basis until all things that I need to get done whit Unity are finished. So yeah, that's why almost all releases are on vacations or when I have a lot of spare time. Although, I will try to get this reviewed in the following week. Maybe it will get released on the weekend, if school doesn't get any more rude.

TL;DR I'll try to check it out next week. If everything is ok I will merge and release on the weekend, promise.

Edit: Thanks for showing interest to both of you. And thank you Vito for the PR, sorry for the very very very very late response :/

@AOx0 AOx0 assigned AOx0 and unassigned AOx0 Oct 24, 2022
@AOx0
Copy link
Collaborator

AOx0 commented Oct 24, 2022

Ups. Misclicked

@VitoBarra
Copy link
Contributor Author

Haha, yeah me neither, it's actually because of this project that I (very) recently started learning a little unity, thankfully just compiling this edition of the game wasn't too hard.

Ahh, the beauty of open source.

hate to be that guy, but is there any word on if/when this will get folded in?

The thing is, I have a 128 GB laptop so downloading Unity and keeping it on my device becomes a nightmare when my average free storage is ~5GB, I have to literally uninstall every program I use on a daily basis until all things that I need to get done whit Unity are finished. So yeah, that's why almost all releases are on vacations or when I have a lot of spare time. Although, I will try to get this reviewed in the following week. Maybe it will get released on the weekend, if school doesn't get any more rude.

TL;DR I'll try to check it out next week. If everything is ok I will merge and release on the weekend, promise.

Edit: Thanks for showing interest to both of you. And thank you Vito for the PR, sorry for the very very very very late response :/

haha that's no problem, I totally understand the time problem in fact I would like to do more for the project but university require time and so I cannot :C

@AOx0 AOx0 mentioned this pull request Dec 1, 2022
Copy link
Collaborator

@AOx0 AOx0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will get merged with PR #37

@AOx0 AOx0 merged commit 23f6a91 into DigitalLogicSimCommunity:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants