Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] GuzzleAdapter. #32

Merged
merged 4 commits into from Jul 30, 2014
Merged

[PR] GuzzleAdapter. #32

merged 4 commits into from Jul 30, 2014

Conversation

liverbool
Copy link
Contributor

GuzzleAdapter PR and some GuzzleAdapterSpec draft.

@yassirh yassirh merged commit d1d2530 into DigitalOceanPHP:master Jul 30, 2014
@yassirh
Copy link
Contributor

yassirh commented Jul 30, 2014

Looks great thanks

@liverbool
Copy link
Contributor Author

@yassirh GuzzleAdapterSpec is not finish, can you fix?

@yassirh
Copy link
Contributor

yassirh commented Jul 30, 2014

Yes i will, thank you! :)

@toin0u
Copy link
Contributor

toin0u commented Jul 30, 2014

👍

@toin0u
Copy link
Contributor

toin0u commented Jul 30, 2014

@liverbool @yassirh 98415e9 :)

@GrahamCampbell
Copy link
Member

If we have a guzzle adapter, why not move buzz into require dev, and add them both to the recomends section?

@GrahamCampbell
Copy link
Member

Also, is there any reason why this was implemented for guzzle 3, and not guzzle 4?

@GrahamCampbell
Copy link
Member

Also, if we were to move it, we'd have to change the branch alias to 0.2-dev because it would be breaking for users.

@toin0u
Copy link
Contributor

toin0u commented Jul 30, 2014

@GrahamCampbell

  • You're right, we should move the buzz lib into require-dev 👍
  • Guzzle 4 requires php >= 5.4.0
  • you're 100% right we need to update the branch-alias in composer.json :)

@GrahamCampbell
Copy link
Member

Just because guzzle 4 requires php 5.4, it doesn't mean we shouldn't support it for those using php 5.4+?

@GrahamCampbell
Copy link
Member

See #33 and #34.

@toin0u
Copy link
Contributor

toin0u commented Jul 30, 2014

I agree, I think we should also support Guzzle 4 :) And thanks for the PR !

@liverbool
Copy link
Contributor Author

I vote to Guzzle 4.
💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants