-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR] GuzzleAdapter. #32
Conversation
Looks great thanks |
@yassirh |
Yes i will, thank you! :) |
👍 |
If we have a guzzle adapter, why not move buzz into require dev, and add them both to the recomends section? |
Also, is there any reason why this was implemented for guzzle 3, and not guzzle 4? |
Also, if we were to move it, we'd have to change the branch alias to 0.2-dev because it would be breaking for users. |
|
Just because guzzle 4 requires php 5.4, it doesn't mean we shouldn't support it for those using php 5.4+? |
I agree, I think we should also support Guzzle 4 :) And thanks for the PR ! |
I vote to Guzzle 4. |
GuzzleAdapter PR and some
GuzzleAdapterSpec
draft.