Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a dateLastProcessed field? #327

Closed
owenrh opened this issue Aug 31, 2016 · 2 comments
Closed

adding a dateLastProcessed field? #327

owenrh opened this issue Aug 31, 2016 · 2 comments

Comments

@owenrh
Copy link

owenrh commented Aug 31, 2016

Hi,

We're looking to add some additional diagnostic capability to the status index by adding a dateLastProcessed field.

We could push it in as a metadata field in our own crawler code, but we were wondering if it would make sense as a top-level field that most storm-crawler users would benefit from?

@jnioche jnioche changed the title Add diagnostic capability to status index? adding a dateLastProcessed field? Aug 31, 2016
@jnioche
Copy link
Contributor

jnioche commented Aug 31, 2016

Thanks @owenrh (and great to see that you joined @mattburns and his gang)

Would that value be different from the fetch date? If so it could be added by the AbstractStatusUpdaterBolt, if not then it would be created by the Fetcher bolt implementations and be called e.g. lastFetchDate to mirror nextFetchDate. Having this could be useful for implementing an adaptive scheduling and it would be good for diagnostics indeed.

@owenrh
Copy link
Author

owenrh commented Aug 31, 2016

Thanks for getting back to me so quickly Julien.

Re: fetch date - it would be the timestamp of the last attempted fetch, so either lastFetchDate or lastProcessedDate would make sense. I think I suggested the latter just because I felt it didn't imply a successful fetch, which I thought lastFetchDate might. (But maybe that's just a matter of documentation).

If you think it would be useful in the core then I'm happy to create a PR for it, and mod the AbstractStatusUpdaterBolt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants