Verify Info Server refactoring and testing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 22, 2018 12:55
mrenoon
reviewed
Nov 28, 2018
test/models/user_test.rb
Outdated
| assert_not user.update(address: address.slice(1)), | ||
| 'should not fall below 42 characters' | ||
|
|
||
| assert_not user.update(address: 'g' + address.slice(2) + 'G'), |
There was a problem hiding this comment.
should be '0xg' + address.slice(4) + 'G' ?
mrenoon
reviewed
Nov 28, 2018
app/models/user.rb
Outdated
| validates :address, | ||
| presence: true, | ||
| uniqueness: true, | ||
| format: { with: /\A0x[a-fA-F0-9]{40}\Z/, |
There was a problem hiding this comment.
Actually, we should use the checksummed version of the address to store in the database. We can use the gem ethereum to convert and check checksummed addresses
Specifications: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-55.md
There was a problem hiding this comment.
Can I use Eth::Utils.valid_address? instead since it is already installed?
|
Pushed the changes but Github is not updating the comments? |
mrenoon
reviewed
Nov 28, 2018
|
|
||
| case result | ||
| when :invalid_data, :database_error | ||
| render json: { errors: challenge_or_error }, |
There was a problem hiding this comment.
Done, also created result_response and error_response to signify a standard success or failure response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main objective:
verify_info_server_requestas a middleware or action filterSecondary objective:
rubocopfor formatting and lintingfactory_botfor fixturessimple_covfor code coverageprovencolumn tochallengesto prevent re-proving a proven challenge