Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adopt forward-compatible approach to builder:watch #476

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

danielroe
Copy link
Collaborator

We are planning to move to emitting absolute paths in builder:watch in Nuxt v4. You can see a little more about the history in the PR linked in that issue.

This PR is an attempt to use a forward/backward compatible approach, namely resolving the path to ensure it's absolute, then making it relative so your existing code will continue to work.

This should be safe to merge as is, but do let me know if you have any concerns about this approach.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.31%. Comparing base (b41470d) to head (887d014).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
+ Coverage   42.22%   42.31%   +0.08%     
==========================================
  Files          26       26              
  Lines        1383     1385       +2     
  Branches      139      139              
==========================================
+ Hits          584      586       +2     
- Misses        778      779       +1     
+ Partials       21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Diizzayy Diizzayy merged commit cf8dfca into main Apr 3, 2024
6 checks passed
@danielroe danielroe deleted the absolute-builder-watch-paths branch April 3, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants