DiligentCore.NET: Base implementation #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikhailGorobets
force-pushed
the
mgorobets
branch
9 times, most recently
from
8cfc0a3
to
3cca222
Compare
MikhailGorobets
force-pushed
the
mgorobets
branch
from
3cca222
to
37e5707
Compare
MikhailGorobets
force-pushed
the
mgorobets
branch
4 times, most recently
from
721f88c
to
82c99c8
Compare
Comment on lines
1
to
52
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <Sdk Name="Diligent-SharpGenTools.Sdk" Version="2.0.0-beta.17" /> | ||
| <PropertyGroup> | ||
| <TargetFramework>net6.0</TargetFramework> | ||
| <LangVersion>10.0</LangVersion> | ||
| <Platforms>x86;x64</Platforms> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <SharpGenEnablePackageReferenceCheck>false</SharpGenEnablePackageReferenceCheck> | ||
| <Nullable>enable</Nullable> | ||
| <PackageProjectUrl>https://github.com/DiligentGraphics/DiligentCore</PackageProjectUrl> | ||
| <RepositoryUrl>https://github.com/DiligentGraphics/DiligentCore</RepositoryUrl> | ||
| <RepositoryType>git</RepositoryType> | ||
| <Company>Diligent Graphics LLC</Company> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <SharpGenMapping Include="Mapping.xml" /> | ||
| </ItemGroup> | ||
| </Project> |
There was a problem hiding this comment.
Can this be generated by CMake?
Cant this be built not my Visual Studio?
| @@ -0,0 +1,443 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Can this file be auto-generated?
| template <typename T, typename = typename std::enable_if<std::is_integral<T>::value>::type> | ||
| constexpr Version(T _Major, T _Minor) noexcept : | ||
| Major{static_cast<decltype(Major)>(_Major)}, | ||
| Minor{static_cast<decltype(Minor)>(_Minor)} | ||
| { | ||
| } | ||
| #else | ||
| constexpr Version(Uint32 _Major, Uint32 _Minor) noexcept : |
There was a problem hiding this comment.
Is template the problem here?
There was a problem hiding this comment.
CastXML uses clang 13.0.0 for parsing C++ code. The latest C++ headers in MSVC require clang version 15.0.0
CastXML/CastXMLSuperbuild#53
MikhailGorobets
force-pushed
the
mgorobets
branch
4 times, most recently
from
3b52345
to
04f36d8
Compare
MikhailGorobets
force-pushed
the
mgorobets
branch
10 times, most recently
from
89dfce7
to
222dd67
Compare
MikhailGorobets
force-pushed
the
mgorobets
branch
from
222dd67
to
b9f42c7
Compare
MikhailGorobets
force-pushed
the
mgorobets
branch
4 times, most recently
from
72f05cc
to
a2cd916
Compare
MikhailGorobets
force-pushed
the
mgorobets
branch
3 times, most recently
from
6fb6e94
to
b878945
Compare
TheMostDiligent
force-pushed
the
mgorobets
branch
from
b878945
to
9632336
Compare
MikhailGorobets
force-pushed
the
mgorobets
branch
from
9632336
to
bfd651e
Compare
TheMostDiligent
force-pushed
the
mgorobets
branch
from
bfd651e
to
10cb467
Compare
MikhailGorobets
force-pushed
the
mgorobets
branch
4 times, most recently
from
d744ccf
to
feb565c
Compare
MikhailGorobets
force-pushed
the
mgorobets
branch
from
feb565c
to
2d716fe
Compare
|
Merged in 6387cb7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.