-
Notifications
You must be signed in to change notification settings - Fork 1
Development process Creating a Pull Request
Dmytro Samodurov edited this page Jul 23, 2018
·
2 revisions
Pull request should conform the following requirements:
- Implement one feature at once, do not include nonrelated changes.
- Contain all related automated tests.
- Contain a short description of a feature/change/fix the PR implements, so that any developer/qa not related to the project can understand the idea.
- Contain a link to the source task (e.g. Jira Issue or Trello card), so that it is easy to find more information about the feature.
- Contain a link to the personal demo server demonstrating the feature in action.
- Contain well described commits only. Messy commits should be rebased/squashed before creating a PR.
- Be green: pass the CI build (if CI is configured).