Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete selected node #231

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

ikorason
Copy link

@ikorason ikorason commented Oct 2, 2023

when there is node selection, if pressed Del on keyboard, will remove that node

@Dimchikkk
Copy link
Owner

@irfanabliz does it interfer with removing selected text inside node?

@ikorason
Copy link
Author

ikorason commented Oct 2, 2023

@StaffEngineer yes it does, it removes the text inside, should keep the text?

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #231 (acf1d1e) into main (e4ac80a) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   12.78%   12.77%   -0.02%     
==========================================
  Files          59       59              
  Lines        7573     7580       +7     
==========================================
  Hits          968      968              
- Misses       6605     6612       +7     
Files Coverage Δ
src/ui_plugin/systems/keyboard.rs 0.00% <0.00%> (ø)

@ikorason
Copy link
Author

ikorason commented Oct 2, 2023

basically it should be the same behaviour as the delete element button for selected node

@Dimchikkk
Copy link
Owner

@irfanabliz when text selected inside node delete should remove text rather than node (if it's current behaviour).

@Dimchikkk
Copy link
Owner

Let me test it tomorrow, not on PC atm.

@ikorason
Copy link
Author

ikorason commented Oct 2, 2023

@irfanabliz when text selected inside node delete should remove text rather than node (if it's current behaviour).

so current behaviour is when selected text inside of the node (node will also be selected) and remove element button will remove the node as well as text inside

@Dimchikkk
Copy link
Owner

Yeah, it's all good... since selected text still can be deleted by backspace key.

@Dimchikkk Dimchikkk merged commit c7e9fb8 into Dimchikkk:main Oct 3, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants