Fix React hooks call order

DimensionDev · Jul 5, 2019 · 1beb457 · 1beb457
1 parent 071418b
commit 1beb457
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/extension/content-script/injections/Posts.tsx b/src/extension/content-script/injections/Posts.tsx
@@ -26,18 +26,22 @@ function PostInspector(props: PostInspectorProps) {
     const { post, postBy, postId } = props
     const whoAmI = (useIdentitiesAtFacebook()[0] || { identifier: PersonIdentifier.unknown }).identifier
     const people = usePeople()
+    const [alreadySelectedPreviously, setAlreadySelectedPreviously] = useState<Person[]>([])
+
     if (postBy.isUnknown) return null
     const type = {
         encryptedPost: deconstructPayload(post),
         provePost: post.match(/🔒(.+)🔒/)!,
     }
+    useAsync(() => {
+        if (!whoAmI.equals(postBy)) return Promise.resolve([])
+        if (!type.encryptedPost) return Promise.resolve([])
+        const { iv } = type.encryptedPost
+        return Services.Crypto.getSharedListOfPost(iv)
+    }, [post]).then(p => setAlreadySelectedPreviously(p))
     if (type.encryptedPost) {
         props.needZip()
-        const [alreadySelectedPreviously, setAlreadySelectedPreviously] = useState<Person[]>([])
         const { iv, ownersAESKeyEncrypted } = type.encryptedPost
-        if (whoAmI.equals(postBy)) {
-            useAsync(() => Services.Crypto.getSharedListOfPost(iv), [post]).then(p => setAlreadySelectedPreviously(p))
-        }
         return (
             <DecryptPostUI.UI
                 requestAppendDecryptor={async people => {

diff --git a/src/social-network/facebook.com/parse-html.ts b/src/social-network/facebook.com/parse-html.ts
@@ -1,5 +1,6 @@
 /**
  * Parse static result from fb
+ * ! TODO: This is not work in Firefox Desktop
  */
 export async function parseFacebookStaticHTML(url: RequestInfo) {
     const request = await fetch(url, { credentials: 'include' })