chore: mf-5169 change persona link (#10646)

* chore: add event tracking for luck send * chore: mf-5169 change persona link
DimensionDev · Aug 28, 2023 · 5367206 · 5367206
1 parent 326c3af
commit 5367206
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 11 deletions.
diff --git a/packages/mask/src/components/CompositionDialog/useSubmit.ts b/packages/mask/src/components/CompositionDialog/useSubmit.ts
@@ -60,6 +60,8 @@ export function useSubmit(onClose: () => void, reason: 'timeline' | 'popup' | 'r
                 const decoratedText = decorateEncryptedText(encrypted, t, content.meta)
                 pasteTextEncode(decoratedText ?? t('additional_post_box__encrypted_post_pre', { encrypted }), reason)
             }
+            if (content.meta?.has(`${PluginID.RedPacket}:1`) || content.meta?.has(`${PluginID.RedPacket}_nft:1`))
+                Telemetry.captureEvent(EventType.Interact, EventID.EntryAppLuckSend)
             Telemetry.captureEvent(EventType.Interact, EventID.EntryMaskComposeEncrypt)
             onClose()
         },

diff --git a/packages/mask/src/extension/popups/components/PersonaPublicKey/index.tsx b/packages/mask/src/extension/popups/components/PersonaPublicKey/index.tsx
@@ -4,7 +4,6 @@ import { formatPersonaFingerprint } from '@masknet/shared-base'
 import { makeStyles } from '@masknet/theme'
 import { Link, Typography } from '@mui/material'
 import { memo } from 'react'
-import urlcat from 'urlcat'
 
 const useStyles = makeStyles<{ iconSize: number }>()((theme, { iconSize }) => ({
     text: {
@@ -47,7 +46,7 @@ export const PersonaPublicKey = memo<PersonaPublicKeyProps>(function PersonaPubl
                 underline="none"
                 target="_blank"
                 rel="noopener noreferrer"
-                href={urlcat('https://web3.bio/', { s: publicHexString })}
+                href={`https://web3.bio/${publicHexString}`}
                 className={classes.icon}>
                 <Icons.LinkOut size={iconSize} />
             </Link>

diff --git a/packages/mask/src/extension/popups/pages/Friends/ContactCard/index.tsx b/packages/mask/src/extension/popups/pages/Friends/ContactCard/index.tsx
@@ -19,7 +19,6 @@ import Services from '../../../../service.js'
 import { useEverSeen } from '@masknet/shared-base-ui'
 import { useFriendProfiles } from '../../../hook/useFriendProfiles.js'
 import { useMutation, useQueryClient, type InfiniteData } from '@tanstack/react-query'
-import urlcat from 'urlcat'
 import { type Friend } from '../../../hook/useFriends.js'
 
 const useStyles = makeStyles()((theme) => ({
@@ -200,7 +199,7 @@ export const ContactCard = memo<ContactCardProps>(function ContactCard({
                                 underline="none"
                                 target="_blank"
                                 rel="noopener noreferrer"
-                                href={urlcat('https://web3.bio/', { s: nextId })}
+                                href={`https://web3.bio/${nextId}`}
                                 className={classes.icon}>
                                 <Icons.LinkOut size={12} />
                             </Link>

diff --git a/packages/mask/src/extension/popups/pages/Friends/Detail/UI.tsx b/packages/mask/src/extension/popups/pages/Friends/Detail/UI.tsx
@@ -10,7 +10,6 @@ import { useTheme } from '@mui/system'
 import { CopyButton, EmptyStatus } from '@masknet/shared'
 import { ConnectedAccounts } from './ConnectAccounts/index.js'
 import { useI18N } from '../../../../../utils/i18n-next-ui.js'
-import urlcat from 'urlcat'
 
 const useStyles = makeStyles()((theme) => ({
     container: {
@@ -136,7 +135,7 @@ export const FriendsDetailUI = memo<FriendsDetailUIProps>(function FriendsDetail
                             underline="none"
                             target="_blank"
                             rel="noopener noreferrer"
-                            href={urlcat('https://web3.bio/', { s: nextId })}
+                            href={`https://web3.bio/${nextId}`}
                             className={classes.icon}>
                             <Icons.LinkOut size={12} />
                         </Link>

diff --git a/packages/mask/src/extension/popups/pages/Personas/components/PersonaHeader/UI.tsx b/packages/mask/src/extension/popups/pages/Personas/components/PersonaHeader/UI.tsx
@@ -4,7 +4,6 @@ import { makeStyles } from '@masknet/theme'
 import { Avatar, Box, Link, Typography } from '@mui/material'
 import { Icons } from '@masknet/icons'
 import { formatPersonaFingerprint, formatPersonaName } from '@masknet/shared-base'
-import urlcat from 'urlcat'
 // import { CopyIconButton } from '../../../../components/CopyIconButton/index.js'
 
 const useStyles = makeStyles()((theme) => ({
@@ -81,7 +80,7 @@ export const PersonaHeaderUI = memo<PersonaHeaderUIProps>(({ avatar, fingerprint
                             underline="none"
                             target="_blank"
                             rel="noopener noreferrer"
-                            href={urlcat('https://web3.bio/', { s: publicHexString })}
+                            href={`https://web3.bio/${publicHexString}`}
                             className={classes.icon}>
                             <Icons.LinkOut size={12} />
                         </Link>

diff --git a/packages/web3-telemetry/src/types/index.ts b/packages/web3-telemetry/src/types/index.ts
@@ -19,10 +19,7 @@ export enum ExceptionType {
 export enum EventID {
     EntryAppLuckOpen = 'entry_app_luck_open',
     EntryAppLuckCreate = 'entry_app_luck_create',
-
-    // todo
     EntryAppLuckSend = 'entry_app_luck_send',
-
     EntryAppNFT_PFP_Open = 'entry_app_nft_pfp_open',
     EntryAppNFT_PFP_Setting = 'entry_app_nft_pfp_setting',
     EntryAppSwapOpen = 'entry_app_swap_open',