fix: mf-5253 list domains for only verified twitter handle (#10821)

DimensionDev · Sep 22, 2023 · 799be0b · 799be0b
1 parent 1003eae
commit 799be0b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/web3-providers/src/Firefly/index.ts b/packages/web3-providers/src/Firefly/index.ts
@@ -16,8 +16,8 @@ export class FireflyAPI implements FireflyBaseAPI.Provider {
         if (result.code !== 200) return EMPTY_LIST
         return result.data
     }
-    async verifyTwitterHandlerByAddress(address: string, handler?: string): Promise<boolean> {
-        if (!handler || !address) return false
+    async verifyTwitterHandleByAddress(address: string, handle?: string): Promise<boolean> {
+        if (!handle || !address) return false
         const response = await fetchJSON<FireflyBaseAPI.VerifyTwitterResult>(
             urlcat(TWITTER_HANDLER_VERIFY_URL, '/v1/relation/handles', {
                 wallet: address.toLowerCase(),
@@ -27,6 +27,6 @@ export class FireflyAPI implements FireflyBaseAPI.Provider {
 
         if ('error' in response) return false
 
-        return response.data.includes(handler) || response.data.filter(Boolean).length === 0
+        return response.data.includes(handle)
     }
 }
diff --git a/packages/web3-providers/src/Web3/EVM/state/IdentityService.ts b/packages/web3-providers/src/Web3/EVM/state/IdentityService.ts
@@ -341,12 +341,14 @@ export class IdentityService extends IdentityServiceState<ChainId> {
         const verifiedResult = await Promise.allSettled(
             uniqBy(identities, (x) => x.address.toLowerCase()).map(async (x) => {
                 const address = x.address.toLowerCase()
-                const isReliable = await Firefly.verifyTwitterHandlerByAddress(address, handle)
+                const isReliable = await Firefly.verifyTwitterHandleByAddress(address, handle)
                 return isReliable ? address : null
             }),
         )
         const trustedAddresses = compact(verifiedResult.map((x) => (x.status === 'fulfilled' ? x.value : null)))
 
-        return identities.filter((x) => trustedAddresses.includes(x.address.toLowerCase())).concat(identitiesFromNextID)
+        return identities
+            .filter((x) => trustedAddresses.includes(x.address.toLowerCase()) || x.type === SocialAddressType.Address)
+            .concat(identitiesFromNextID)
     }
 }