Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spa theme #10331

Merged
merged 5 commits into from
Aug 10, 2023
Merged

fix: spa theme #10331

merged 5 commits into from
Aug 10, 2023

Conversation

lelenei
Copy link
Contributor

@lelenei lelenei commented Aug 9, 2023

Description

Closes mf-4786

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@lelenei lelenei added this to the 2.22.0 milestone Aug 9, 2023
@github-actions github-actions bot temporarily deployed to pull request August 9, 2023 14:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 9, 2023 16:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 9, 2023 23:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 9, 2023 23:45 Inactive
const systemMode = useSystemPreferencePalette()
const setThemeMode = useSetThemeMode()
const mode = useThemeMode()

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a flickering between switching themes during startup, you can deal with it with useLayoutEffect.

@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 04:29 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 05:00 Inactive
@guanbinrui guanbinrui merged commit faca8a6 into develop Aug 10, 2023
15 checks passed
@guanbinrui guanbinrui deleted the lelenei/mf-4786 branch August 10, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants