Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bugfix for encrypted contacts #10337

Merged
merged 18 commits into from
Aug 10, 2023
Merged

fix: bugfix for encrypted contacts #10337

merged 18 commits into from
Aug 10, 2023

Conversation

beyond009
Copy link
Contributor

Description

https://mask.atlassian.net/browse/MF-4805
https://mask.atlassian.net/browse/MF-4808
https://mask.atlassian.net/browse/MF-4807
https://mask.atlassian.net/browse/MF-4806
https://mask.atlassian.net/browse/MF-4809
https://mask.atlassian.net/browse/MF-4810
https://mask.atlassian.net/browse/MF-4811
https://mask.atlassian.net/browse/MF-4812
https://mask.atlassian.net/browse/MF-4825

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 03:33 Inactive
@beyond009 beyond009 added this to the 2.22.0 milestone Aug 10, 2023
@beyond009 beyond009 changed the base branch from develop to feat/new-popup-navigation August 10, 2023 05:26
@beyond009 beyond009 changed the base branch from feat/new-popup-navigation to develop August 10, 2023 05:27
guanbinrui
guanbinrui reviewed Aug 10, 2023
View reviewed changes
packages/mask/src/extension/popups/hook/useFriends.ts Outdated

export function useFriends(network: string): AsyncStateRetry<FriendsInformation[]> {
export const PlatformSort = {
twitter: 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use enum.

guanbinrui
guanbinrui reviewed Aug 10, 2023
View reviewed changes
packages/mask/src/extension/popups/hook/useFriendsFromSearch.tsx Outdated
Comment on lines 37 to 38
: PlatformSort[a.platform as keyof typeof PlatformSort] -
PlatformSort[b.platform as keyof typeof PlatformSort],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: PlatformSort[a.platform as keyof typeof PlatformSort] -
PlatformSort[b.platform as keyof typeof PlatformSort],
: PlatformSort[a.platform] -
PlatformSort[b.platform],

@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 05:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 06:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 10, 2023 06:57 Inactive
@guanbinrui guanbinrui merged commit 4262b33 into develop Aug 10, 2023
15 checks passed
@guanbinrui guanbinrui deleted the fix/encrypted-contacts branch August 10, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guanbinrui guanbinrui guanbinrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beyond009 @guanbinrui