fix: token/send issues #10361
Merged
fix: token/send issues #10361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanbinrui
reviewed
Aug 11, 2023
guanbinrui
reviewed
Aug 11, 2023
| pluginID?: T, | ||
| options?: ConnectionOptions<T>, | ||
| /** Allow to control the request */ | ||
| enabled = true, |
There was a problem hiding this comment.
Exporting this critical option is enough. Using an option needs to handle merging with the one inside, makes it complicate.
guanbinrui
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mask.atlassian.net/browse/MF-4879
https://mask.atlassian.net/browse/MF-4887
https://mask.atlassian.net/browse/MF-4888
https://mask.atlassian.net/browse/MF-4889
https://mask.atlassian.net/browse/MF-4893
https://mask.atlassian.net/browse/MF-4897
https://mask.atlassian.net/browse/MF-4872
https://mask.atlassian.net/browse/MF-4876
https://mask.atlassian.net/browse/MF-4880
https://mask.atlassian.net/browse/MF-4903