Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mixpanel sdk #10395

Merged
merged 6 commits into from
Aug 15, 2023
Merged

feat: mixpanel sdk #10395

merged 6 commits into from
Aug 15, 2023

Conversation

guanbinrui
Copy link
Member

Description

Closes MF-0000

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@guanbinrui guanbinrui added this to the 2.22.0 milestone Aug 14, 2023
@guanbinrui guanbinrui force-pushed the feat/mixpanel branch 2 times, most recently from ce7c002 to c467028 Compare August 14, 2023 15:17
@github-actions github-actions bot temporarily deployed to pull request August 14, 2023 15:23 Inactive
@guanbinrui guanbinrui marked this pull request as ready for review August 14, 2023 15:35
@github-actions github-actions bot temporarily deployed to pull request August 14, 2023 15:44 Inactive
@guanbinrui guanbinrui force-pushed the feat/mixpanel branch 2 times, most recently from fc84e9b to 4a5736a Compare August 14, 2023 15:49
@github-actions github-actions bot temporarily deployed to pull request August 15, 2023 04:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 15, 2023 05:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 15, 2023 08:02 Inactive
@guanbinrui guanbinrui force-pushed the feat/mixpanel branch 2 times, most recently from f9d90b8 to a1188da Compare August 15, 2023 09:30
@github-actions github-actions bot temporarily deployed to pull request August 15, 2023 09:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 15, 2023 09:46 Inactive
@guanbinrui guanbinrui force-pushed the feat/mixpanel branch 2 times, most recently from 846205b to d005a5b Compare August 15, 2023 10:04
@github-actions github-actions bot temporarily deployed to pull request August 15, 2023 10:09 Inactive
@guanbinrui guanbinrui merged commit 77d0cdd into develop Aug 15, 2023
15 checks passed
@guanbinrui guanbinrui deleted the feat/mixpanel branch August 15, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant