Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mf-4475 ito swap #10397

Merged
merged 3 commits into from
Aug 15, 2023
Merged

fix: mf-4475 ito swap #10397

merged 3 commits into from
Aug 15, 2023

Conversation

zhouhanseng
Copy link
Contributor

Description

https://mask.atlassian.net/browse/MF-4475

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@zhouhanseng zhouhanseng added this to the 2.22.0 milestone Aug 15, 2023
@github-actions github-actions bot temporarily deployed to pull request August 15, 2023 01:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 15, 2023 01:53 Inactive
): () => Promise<
| { receipt: TransactionReceipt | null; events: { [eventName: string]: EventLog | undefined } | undefined }
| undefined
> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inferred type of 'useSwapCallback' cannot be named without a reference to '../../../../../web3-contracts/node_modules/web3-core/types/index.js'. This is likely not portable. A type annotation is necessary.

@github-actions github-actions bot temporarily deployed to pull request August 15, 2023 02:01 Inactive
@guanbinrui guanbinrui merged commit 1710f6d into develop Aug 15, 2023
15 checks passed
@guanbinrui guanbinrui deleted the fix-ito-swap branch August 15, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants