fix: mf-4979 setting jump link #10427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanbinrui
reviewed
Aug 16, 2023
Comment on lines
73
to
80
| browser.tabs.create({ | ||
| active: true, | ||
| url: browser.runtime.getURL(`/dashboard.html#${DashboardRoutes.Settings}`), | ||
| }) | ||
| if (navigator.userAgent.includes('Firefox')) { | ||
| window.close() | ||
| } | ||
| Services.Helper.removePopupWindow() |
There was a problem hiding this comment.
Suggested change
| browser.tabs.create({ | |
| active: true, | |
| url: browser.runtime.getURL(`/dashboard.html#${DashboardRoutes.Settings}`), | |
| }) | |
| if (navigator.userAgent.includes('Firefox')) { | |
| window.close() | |
| } | |
| Services.Helper.removePopupWindow() | |
| await browser.tabs.create({ | |
| active: true, | |
| url: browser.runtime.getURL(`/dashboard.html#${DashboardRoutes.Settings}`), | |
| }) | |
| if (navigator.userAgent.includes('Firefox')) { | |
| window.close() | |
| } | |
| await Services.Helper.removePopupWindow() |
guanbinrui
reviewed
Aug 16, 2023
| } else if (b.createdAt.getTime() - a.createdAt.getTime() > 10000) { | ||
| return 1 | ||
| } | ||
| const numA = a.name.split('Wallet ')[1] |
There was a problem hiding this comment.
A wallet's name could be altered by the user.
There was a problem hiding this comment.
This sorting only targets our default generate name.
guanbinrui
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://mask.atlassian.net/browse/MF-4979
https://mask.atlassian.net/browse/MF-4916
https://mask.atlassian.net/browse/MF-4978
https://mask.atlassian.net/browse/MF-4984
Closes # (NO_ISSUE)
Type of change
Previews
Checklist
console.logsIf this PR depends on external APIs:
chrome-extension://[id]moz-extension://[id]