Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: i18n setup persona #10626

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

nuanyang233
Copy link
Collaborator

@nuanyang233 nuanyang233 commented Aug 25, 2023

Description

Closes #MF-5146 MF-5166

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@nuanyang233 nuanyang233 added this to the 2.22.2 milestone Aug 25, 2023
@nuanyang233 nuanyang233 marked this pull request as draft August 25, 2023 10:47
@nuanyang233 nuanyang233 marked this pull request as ready for review August 25, 2023 10:50
@guanbinrui guanbinrui merged commit 2f52f8c into hotfix/2.22.2 Aug 25, 2023
16 checks passed
@guanbinrui guanbinrui deleted the chore/i18n-setup-persona branch August 25, 2023 11:10
guanbinrui pushed a commit that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants