Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mf-4992 change event tracking #10630

Merged
merged 13 commits into from
Aug 26, 2023
Merged

chore: mf-4992 change event tracking #10630

merged 13 commits into from
Aug 26, 2023

Conversation

beyond009
Copy link
Contributor

@beyond009 beyond009 commented Aug 25, 2023 •
edited by guanbinrui

Description

Closes MF-4992

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions github-actions bot temporarily deployed to pull request August 25, 2023 15:40 Inactive
@guanbinrui guanbinrui added this to the 2.23.0 milestone Aug 26, 2023
guanbinrui and others added 2 commits August 26, 2023 12:05
@guanbinrui
refactor: MF-4992 change entry (#10631)
f4fa6cc 
* refactor: mf-4992

* refactor: hooks

* refactor: naming

* refactor: code style
@guanbinrui
refactor: code style
35af07d
@github-actions github-actions bot temporarily deployed to pull request August 26, 2023 04:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 26, 2023 04:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 26, 2023 06:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 26, 2023 06:34 Inactive
@guanbinrui guanbinrui merged commit 3eab83a into develop Aug 26, 2023
15 checks passed
@guanbinrui guanbinrui deleted the chore/mf-4992-change-entry branch August 26, 2023 12:07
guanbinrui added a commit that referenced this pull request Aug 28, 2023
@beyond009 @guanbinrui
chore: mf-4992 change event tracking (#10630)
9123236 
* feat: add telemetry for redpack

* fix: mf-5133

* chore: update entry point

* chore: update entry point

* chore: update profile  entry

* chore: update dsearch entry

* chore: update dsearch entry

* refactor: MF-4992 change entry (#10631)

* refactor: mf-4992

* refactor: hooks

* refactor: naming

* refactor: code style

* refactor: code style

* fix: type errors

* fix: type error

---------

Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
Co-authored-by: guanbinrui <guanbinrui@dimension.im>
guanbinrui added a commit that referenced this pull request Aug 28, 2023
@beyond009 @guanbinrui
chore: mf-4992 change event tracking (#10630)
4d3b83d 
* feat: add telemetry for redpack

* fix: mf-5133

* chore: update entry point

* chore: update entry point

* chore: update profile  entry

* chore: update dsearch entry

* chore: update dsearch entry

* refactor: MF-4992 change entry (#10631)

* refactor: mf-4992

* refactor: hooks

* refactor: naming

* refactor: code style

* refactor: code style

* fix: type errors

* fix: type error

---------

Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
Co-authored-by: guanbinrui <guanbinrui@dimension.im>
guanbinrui added a commit that referenced this pull request Aug 28, 2023
@beyond009 @guanbinrui
chore: mf-4992 change event tracking (#10630)
59643e9 
* feat: add telemetry for redpack

* fix: mf-5133

* chore: update entry point

* chore: update entry point

* chore: update profile  entry

* chore: update dsearch entry

* chore: update dsearch entry

* refactor: MF-4992 change entry (#10631)

* refactor: mf-4992

* refactor: hooks

* refactor: naming

* refactor: code style

* refactor: code style

* fix: type errors

* fix: type error

---------

Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
Co-authored-by: guanbinrui <guanbinrui@dimension.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beyond009 @guanbinrui