Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bugfix for timeline calendar #10798

Merged
merged 8 commits into from
Sep 20, 2023
Merged

fix: bugfix for timeline calendar #10798

merged 8 commits into from
Sep 20, 2023

Conversation

beyond009
Copy link
Contributor

@beyond009 beyond009 commented Sep 19, 2023 •
edited by guanbinrui

Description

Closes https://mask.atlassian.net/browse/MF-5282
Closes https://mask.atlassian.net/browse/MF-5283
Closes https://mask.atlassian.net/browse/MF-5284
Closes https://mask.atlassian.net/browse/MF-5286
Closes https://mask.atlassian.net/browse/MF-5287
Closes https://mask.atlassian.net/browse/MF-5291
Closes https://mask.atlassian.net/browse/MF-5292
Closes https://mask.atlassian.net/browse/MF-5293
Closes https://mask.atlassian.net/browse/MF-5295
Closes https://mask.atlassian.net/browse/MF-5296

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 02:48 Inactive
@guanbinrui guanbinrui added this to the 2.23.0 milestone Sep 20, 2023
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 02:52 Inactive
@guanbinrui guanbinrui merged commit 5360230 into develop Sep 20, 2023
16 of 17 checks passed
@guanbinrui guanbinrui deleted the fix/mf-4948-timeline-calendar branch September 20, 2023 02:54
guanbinrui added a commit that referenced this pull request Sep 20, 2023
@beyond009 @guanbinrui
fix: bugfix for timeline calendar (#10798)
75dea4e 
* fix: ui/ux

* fix: mf-5291 event tab

* fix: mf-5282

* fix: mf-5283

* fix: ui/ux

* fix: ui/ux

* chore: revert lock file changes

---------

Co-authored-by: guanbinrui <guanbinrui@dimension.im>
Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
guanbinrui added a commit that referenced this pull request Sep 20, 2023
@beyond009 @guanbinrui
fix: bugfix for timeline calendar (#10798)
b42b42b 
* fix: ui/ux

* fix: mf-5291 event tab

* fix: mf-5282

* fix: mf-5283

* fix: ui/ux

* fix: ui/ux

* chore: revert lock file changes

---------

Co-authored-by: guanbinrui <guanbinrui@dimension.im>
Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beyond009 @guanbinrui