Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bugfix for backup #10870

Merged
merged 3 commits into from
Sep 27, 2023
Merged

fix: bugfix for backup #10870

merged 3 commits into from
Sep 27, 2023

Conversation

nuanyang233
Copy link
Collaborator

Description

Closes # MF-5396 MF-5401 MF-5402 MF-5404 MF-5407 MF-5409 MF-5410 MF-5411

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@nuanyang233 nuanyang233 added this to the 2.23.0 milestone Sep 26, 2023
@guanbinrui guanbinrui merged commit b153432 into release/2.23.0 Sep 27, 2023
13 checks passed
@guanbinrui guanbinrui deleted the fix/bugfix-for-backup branch September 27, 2023 02:39
guanbinrui added a commit that referenced this pull request Sep 27, 2023
@nuanyang233 @guanbinrui
fix: bugfix for backup (#10870)
4d49275 
* fix: bugfix for backup and release

* refactor: remove logs

---------

Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guanbinrui guanbinrui guanbinrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nuanyang233 @guanbinrui