Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change calendar api #10995

Merged
merged 3 commits into from
Oct 18, 2023
Merged

chore: change calendar api #10995

merged 3 commits into from
Oct 18, 2023

Conversation

beyond009
Copy link
Contributor

@beyond009 beyond009 commented Oct 18, 2023 •
edited

Description

https://mask.atlassian.net/browse/MF-5511

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@beyond009 beyond009 added this to the 2.23.4 milestone Oct 18, 2023
@guanbinrui guanbinrui merged commit 9993df7 into hotfix/2.23.4 Oct 18, 2023
17 of 18 checks passed
@guanbinrui guanbinrui deleted the chore/change-calendar-api branch October 18, 2023 06:20
guanbinrui added a commit that referenced this pull request Oct 19, 2023
@guanbinrui @beyond009 @UncleBill
[Release] Hotfix 2.23.3 => 2.23.4 (patch) (#10992)
307729c 
* chore: bump version to 2.23.4

* chore: change calendar api (#10994)

* chore: change calendar api (#10995)

* chore: change calendar api

* chore: change calendar api

* fix: news list same key (#10996)

* feat: mf-5475 add scroll chain (#10971)

* fix: type error (#10999)

* fixup! feat: mf-5475 add scroll chain (#11001)

* fix: mf-5520 add debank scroll chain name (#11003)

* fix: update scroll icon (#11004)

* fixup! fix: update scroll icon (#11004) (#11006)

* fix: web3 selector (#11007)

* fix: the web3/more injection

* refactor: code style

* fix: mf-5518 add scroll chain name for rabby (#11008)

---------

Co-authored-by: Harlan Sun <33143119+beyond009@users.noreply.github.com>
Co-authored-by: UncleBill <billbill290@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.23.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beyond009 @guanbinrui