Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mf-5340 optimize swap #11295

Merged
merged 4 commits into from Jan 17, 2024
Merged

fix: mf-5340 optimize swap #11295

merged 4 commits into from Jan 17, 2024

Conversation

beyond009
Copy link
Contributor

Description

Closes # (NO_ISSUE)
https://mask.atlassian.net/browse/MF-5340
https://mask.atlassian.net/browse/MF-5484
https://mask.atlassian.net/browse/MF-5492
https://mask.atlassian.net/browse/MF-5493
https://mask.atlassian.net/browse/MF-5494
https://mask.atlassian.net/browse/MF-5498

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@beyond009 beyond009 added this to the 2.25.0 milestone Jan 17, 2024
Comment on lines +48 to +50
ONE_QUARTE = '15 Min',
TWO_QUARTE = '30 Min',
ONE_HOUR = '60 Min',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ONE_QUARTE = '15 Min',
TWO_QUARTE = '30 Min',
ONE_HOUR = '60 Min',
ONE_QUARTE = '15 Mins',
TWO_QUARTE = '30 Mins',
ONE_HOUR = '60 Mins',

@guanbinrui guanbinrui merged commit 23303a4 into develop Jan 17, 2024
14 of 15 checks passed
@guanbinrui guanbinrui deleted the fix/mf-5340 branch January 17, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants