fix: mf-5994 check if ValueRef is ready #11296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Works
reviewed
Jan 17, 2024
| @@ -34,7 +34,16 @@ useActivatedPluginsSiteAdaptor.visibility = { | |||
| } | |||
|
|
|||
| export function useIsMinimalMode(pluginID: string) { | |||
| return useValueRef(minimalModeSub).includes(pluginID) | |||
There was a problem hiding this comment.
why do you need this change? useValueRef already handles readyPromise.
There was a problem hiding this comment.
The result was false by default, that's arbitrary.
There was a problem hiding this comment.
@Jack-Works Any other questions?
There was a problem hiding this comment.
the use(ref.readyPromise) should suspend the render, you should not get a "default" value before the readyPromise is resolved.
There was a problem hiding this comment.
if (!ref2.nowReady) use(ref2.readyPromise)Should be
if (!ref2.ready) use(ref2.readyPromise)
UncleBill
force-pushed
the
fix/mf-5994-minimal-mode
branch
from
3c18c39
to
f65ef7e
Compare
UncleBill
changed the title
Jack-Works
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mask.atlassian.net/browse/MF-5994