Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugfix for redpacket history #11376

Merged
merged 17 commits into from
Feb 8, 2024
Merged

fix: bugfix for redpacket history #11376

merged 17 commits into from
Feb 8, 2024

Conversation

beyond009
Copy link
Contributor

@beyond009 beyond009 commented Feb 7, 2024

Description

Closes # (NO_ISSUE)
MF-0000 FW-372 FW-313 FW-363 FW-380 FW-381 FW-382 FW-384 FW-397

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@beyond009 beyond009 added this to the 2.25.0 milestone Feb 7, 2024
}) {
const { platform, postId, className } = props
return (
<button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use <a /> link.

const res = await FireflyRedPacket.getHistory(
historyType,
account as `0x${string}`,
FireflyRedPacketAPI.SourceType.FireflyPC,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also use this component in Mask Network extension?

: null}
<Box>
{claimList.length ?
claimList.map((item) => (
<div className={classes.claimer} key={item.creator}>
<FireflyRedPacketAccountItem address={item.creator} />
<FireflyRedPacketAccountItem address={item.creator} chainId={Number(claimInfo?.chain_id)} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Process data as wish when we received it from server.

@guanbinrui guanbinrui merged commit e4bc33c into firefly-rp Feb 8, 2024
5 checks passed
@guanbinrui guanbinrui deleted the fix/rp-history branch February 8, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants