Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: query proof service #11452

Merged
merged 3 commits into from Feb 27, 2024
Merged

refactor: query proof service #11452

merged 3 commits into from Feb 27, 2024

Conversation

guanbinrui
Copy link
Member

Description

Closes MF-0000

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@guanbinrui guanbinrui added this to the 2.25.0 milestone Feb 27, 2024
@guanbinrui guanbinrui marked this pull request as ready for review February 27, 2024 04:00
@guanbinrui guanbinrui merged commit e746038 into hotfix/2.24.6 Feb 27, 2024
13 checks passed
@guanbinrui guanbinrui deleted the refactor/query-proof-service branch February 27, 2024 04:00
Jack-Works pushed a commit that referenced this pull request Feb 27, 2024
@guanbinrui @Jack-Works
refactor: query proof service (#11452)
a8e23e2 
* refactor: code style

* chore: squash requests

* refactor: reduce abuse using
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.25.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@guanbinrui